Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Searching: Support Aggregations #2585

Closed
reta opened this issue Mar 24, 2022 · 8 comments
Closed

Concurrent Searching: Support Aggregations #2585

reta opened this issue Mar 24, 2022 · 8 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations

Comments

@reta
Copy link
Collaborator

reta commented Mar 24, 2022

Is your feature request related to a problem? Please describe.
The aggregations are implemented using Apache Lucene collectors and are not yet compatible with the concurrent search over segments.

Describe the solution you'd like
It should be possible to use concurrent search over segments for aggregations.

Describe alternatives you've considered
The implementation falls back to sequential search right now

Additional context
N/A

@reta reta added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 24, 2022
@sohami
Copy link
Collaborator

sohami commented Mar 2, 2023

@reta I will be taking a stab at this but wanted to check if there is any initial analysis which you did which can help with this item ?

@sohami
Copy link
Collaborator

sohami commented Mar 2, 2023

@anasalkouz I see this item listed in Fast Follow-Up of Searchable Snapshot but there is no assignee for it. So assuming I can look into this issue ?

@anasalkouz
Copy link
Member

Sure @sohami. Go for it. Please see this META issue for whole effort related to concurrent search. I think @reta took the first stab on implementing the concurrent search as a sandbox plugin.

@reta
Copy link
Collaborator Author

reta commented Mar 3, 2023

@sohami @anasalkouz the main blocker for any further work is this issue [1], the concurrent search sandbox plugin is not published anywhere and we do not provide a convenient way for people to try it. It is just sitting in the repo, unless someone does manual builds and installation.

[1] #3677

@sohami
Copy link
Collaborator

sohami commented Mar 20, 2023

@reta Sorry for delayed response. That issue seems more on to help users of concurrent search to easily try the experimental feature which from discussion seems like we can move to a feature flag model. However, there should not be a blocker from developing other missing pieces. To that I was able to spend some cycles on looking into current implementation and will be adding some update this week.

@sohami
Copy link
Collaborator

sohami commented Mar 22, 2023

@reta @anasalkouz I have added details in a new issue: #6798. Was unable to update the description of this issue. Also I am wondering if we can add all the tasks list in a single place potentially reference #3677 and #6798 to the META issue #2587 itself

@anasalkouz
Copy link
Member

@sohami I have updated the META Issue. Shall I close this issue in the favor of #6798 ?

@sohami
Copy link
Collaborator

sohami commented Mar 27, 2023

@anasalkouz Sounds good. Thanks!

@jed326 jed326 closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations
Projects
Status: Done
Development

No branches or pull requests

5 participants