[BUG] DEB/RPM of OS Core does not include the `agent` folder as in Tar/Zip

[peterzhuamazon]

Describe the bug

[BUG] DEB/RPM of OS Core does not include the agent folder as in Tar/Zip

The final DEB/RPM bundle that is based on the core DEB/RPM artifact failed to start:
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0-beta1/11001/linux/x64/rpm/dist/opensearch/opensearch-3.0.0-beta1-linux-x64.rpm

-- The start-up result is done.
Apr 12 05:02:54 1e3522934a87 systemd[1]: -.slice: Failed to set memory.limit_in_bytes: Invalid argument
Apr 12 05:02:54 1e3522934a87 systemd[1]: Starting OpenSearch...
-- Subject: Unit opensearch.service has begun start-up
-- Defined-By: systemd
-- Support: https://access.redhat.com/support
--
-- Unit opensearch.service has begun starting up.
Apr 12 05:02:56 1e3522934a87 opensearch[471]: Exception in thread "main" java.lang.RuntimeException: starting java failed with [1]
Apr 12 05:02:56 1e3522934a87 opensearch[471]: output:
Apr 12 05:02:56 1e3522934a87 opensearch[471]: Error occurred during initialization of VM
Apr 12 05:02:56 1e3522934a87 opensearch[471]: agent library failed Agent_OnLoad: instrument
Apr 12 05:02:56 1e3522934a87 opensearch[471]: error:
Apr 12 05:02:56 1e3522934a87 opensearch[471]: Error opening zip file or JAR manifest missing : agent/opensearch-agent.jar
Apr 12 05:02:56 1e3522934a87 opensearch[471]:         at org.opensearch.tools.launchers.JvmErgonomics.flagsFinal(JvmErgonomics.java:125)
Apr 12 05:02:56 1e3522934a87 opensearch[471]:         at org.opensearch.tools.launchers.JvmErgonomics.finalJvmOptions(JvmErgonomics.java:87)
Apr 12 05:02:56 1e3522934a87 opensearch[471]:         at org.opensearch.tools.launchers.JvmErgonomics.choose(JvmErgonomics.java:70)
Apr 12 05:02:56 1e3522934a87 opensearch[471]:         at org.opensearch.tools.launchers.JvmOptionsParser.jvmOptions(JvmOptionsParser.java:150)
Apr 12 05:02:56 1e3522934a87 opensearch[471]:         at org.opensearch.tools.launchers.JvmOptionsParser.main(JvmOptionsParser.java:108)
Apr 12 05:02:56 1e3522934a87 systemd[1]: opensearch.service: Main process exited, code=exited, status=1/FAILURE
Apr 12 05:02:56 1e3522934a87 systemd[1]: opensearch.service: Failed with result 'exit-code'.

There are two issues cause this:

1. OS Core does not seem to include the agent folder as part of their initial deb/rpm core artifact therefore build repo script did not detect them when assembling the bundle: @kumargu @RajatGupta02

You can manually build the core artifact with `./gradlew :distribution:packages:deb:assemble`

(https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0-beta1/11001/linux/x64/deb/builds/opensearch/dist/opensearch-min_3.0.0-beta1_amd64.deb)
% ls deb 
bin  jdk  lib  modules  NOTICE.txt  plugins  README.md

(https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.0.0-beta1/11001/linux/x64/tar/builds/opensearch/dist/opensearch-min-3.0.0-beta1-linux-x64.tar.gz)
# Ignore config/logs/LICENSE.txt as they are in different dir of deb
% ls tar 
agent  bin  config  jdk  lib  LICENSE.txt  logs  modules  NOTICE.txt  plugins  README.md

2. Add the folder to the build repo build scripts: @peterzhuamazon

Thanks.

Related component

Other

To Reproduce

See above.

Expected behavior

See above.

Additional Details

See above.

[peterzhuamazon]

cc: @reta @andrross @kumargu @RajatGupta02 @getsaurabh02

[RajatGupta02]

I tried to reproduce it as follows:
ran ./gradlew :distribution:packages:deb:assemble and did not find the agent folder which was the issue, so to fix that I tried adding this block inside OpenSearch/distribution/packages/build.gradle:

into('/usr/share/opensearch') {

  // ...rest of the config...

  into('agent') {
    with agentFiles()
  }
  
  // ...rest of the config...
}

After which I again built the package with the above command and now on listing its contents i get:

-rw-r--r-- root/root   8953594 2025-04-12 04:19 ./usr/share/opensearch/agent/byte-buddy-1.17.5.jar
-rw-r--r-- root/root     19347 2025-04-12 04:19 ./usr/share/opensearch/agent/opensearch-agent.jar
-rw-r--r-- root/root     11189 2025-04-12 04:19 ./usr/share/opensearch/agent/opensearch-agent-bootstrap-3.0.0-SNAPSHOT.jar

I am not sure if its the right way to fix this?
Thanks

[reta]

I am not sure if its the right way to fix this?

Yeah, it was definitely a miss, @RajatGupta02 could you send a pull request please? thank you

[RajatGupta02]

Yeah sure, will raise the pr in a few minutes. thanks