Add javadocs and fix SIMPLEFS enum order

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
opensearch-project · Dec 1, 2021 · 811ddc2 · 811ddc2
1 parent 6f1d95e
commit 811ddc2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/index/store/FsDirectoryFactory.java b/server/src/main/java/org/opensearch/index/store/FsDirectoryFactory.java
@@ -98,9 +98,10 @@ protected Directory newFSDirectory(Path location, LockFactory lockFactory, Index
                 } else {
                     return primaryDirectory;
                 }
-            case SIMPLEFS:
             case MMAPFS:
                 return setPreload(new MMapDirectory(location, lockFactory), lockFactory, preLoadExtensions);
+            // simplefs was removed in Lucene 9; support for enum is maintained for bwc
+            case SIMPLEFS:
             case NIOFS:
                 return new NIOFSDirectory(location, lockFactory);
             default:

diff --git a/server/src/test/java/org/opensearch/index/store/FsDirectoryFactoryTests.java b/server/src/test/java/org/opensearch/index/store/FsDirectoryFactoryTests.java
@@ -156,6 +156,7 @@ private void doTestStoreDirectory(Path tempDir, String typeSettingValue, IndexMo
                 case HYBRIDFS:
                     assertTrue(FsDirectoryFactory.isHybridFs(directory));
                     break;
+                // simplefs was removed in Lucene 9; support for enum is maintained for bwc
                 case SIMPLEFS:
                 case NIOFS:
                     assertTrue(type + " " + directory.toString(), directory instanceof NIOFSDirectory);