Fixes detected file handle leaks

Signed-off-by: Olasoji Denloye <olasoji.denloye@intel.com>
opensearch-project · Jul 25, 2023 · 3de05e1 · 3de05e1
1 parent 0dc4568
commit 3de05e1
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/server/src/main/java/org/opensearch/index/store/CryptoDirectory.java b/server/src/main/java/org/opensearch/index/store/CryptoDirectory.java
@@ -125,25 +125,31 @@ public final class CryptoDirectory extends NIOFSDirectory {
     }
 
     private void storeWrappedKey(byte[] wrappedKey) {
+        IndexOutput out = null;
         try {
-            IndexOutput out = super.createOutput("keyfile", new IOContext());
+            out = super.createOutput("keyfile", new IOContext());
             out.writeInt(wrappedKey.length);
             out.writeBytes(wrappedKey, 0, wrappedKey.length);
             out.close();
         } catch (IOException e) {
             throw new RuntimeException(e);
+        } finally {
+            if (out != null) IOUtils.closeWhileHandlingException(out);
         }
     }
 
     private byte[] getWrappedKey() {
+        IndexInput in = null;
         try {
-            IndexInput in = super.openInput("keyfile", new IOContext());
+            in = super.openInput("keyfile", new IOContext());
             int size = in.readInt();
             byte[] ret = new byte[size];
             in.readBytes(ret, 0, size);
             return ret;
         } catch (IOException e) {
             throw new RuntimeException(e);
+        } finally {
+            if (in != null) IOUtils.closeWhileHandlingException(in);
         }
     }