Changes

Fix spotless check Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
opensearch-project · Oct 19, 2022 · 05eb55a · 05eb55a
1 parent 4bfd385
commit 05eb55a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/decommission/DecommissionService.java b/server/src/main/java/org/opensearch/cluster/decommission/DecommissionService.java
@@ -418,22 +418,24 @@ private static void validateAwarenessAttribute(
     }
 
     private static void ensureToBeDecommissionedAttributeWeighedAway(ClusterState state, DecommissionAttribute decommissionAttribute) {
-        String msg = null;
         WeightedRoutingMetadata weightedRoutingMetadata = state.metadata().weightedRoutingMetadata();
         if (weightedRoutingMetadata == null) {
-            throw new DecommissioningFailedException(decommissionAttribute,
+            throw new DecommissioningFailedException(
+                decommissionAttribute,
                 "no weights are set to the attribute. Please set appropriate weights before triggering decommission action"
             );
         }
         WeightedRouting weightedRouting = weightedRoutingMetadata.getWeightedRouting();
         if (weightedRouting.attributeName().equals(decommissionAttribute.attributeName()) == false) {
-            throw new DecommissioningFailedException(decommissionAttribute,
+            throw new DecommissioningFailedException(
+                decommissionAttribute,
                 "no weights are specified to attribute [" + decommissionAttribute.attributeName() + "]"
             );
         }
         Double attributeValueWeight = weightedRouting.weights().get(decommissionAttribute.attributeValue());
         if (attributeValueWeight == null || attributeValueWeight.equals(0.0)) {
-            throw new DecommissioningFailedException(decommissionAttribute,
+            throw new DecommissioningFailedException(
+                decommissionAttribute,
                 "weight for decommissioned attribute is expected to be [0.0] but found [" + attributeValueWeight + "]"
             );
         }

diff --git a/server/src/main/java/org/opensearch/cluster/routing/WeightedRoutingService.java b/server/src/main/java/org/opensearch/cluster/routing/WeightedRoutingService.java
@@ -71,7 +71,7 @@ public void registerWeightedRoutingMetadata(
             @Override
             public ClusterState execute(ClusterState currentState) {
                 // verify currently no decommission action is ongoing
-                ensureNoDecommissionActionOngoing(currentState);
+                ensureNoOngoingDecommissionAction(currentState);
                 Metadata metadata = currentState.metadata();
                 Metadata.Builder mdBuilder = Metadata.builder(currentState.metadata());
                 WeightedRoutingMetadata weightedRoutingMetadata = metadata.custom(WeightedRoutingMetadata.TYPE);
@@ -159,7 +159,7 @@ public void verifyAwarenessAttribute(String attributeName) {
         }
     }
 
-    public void ensureNoDecommissionActionOngoing(ClusterState state) {
+    public void ensureNoOngoingDecommissionAction(ClusterState state) {
         DecommissionAttributeMetadata decommissionAttributeMetadata = state.metadata().decommissionAttributeMetadata();
         if (decommissionAttributeMetadata != null && decommissionAttributeMetadata.status().equals(DecommissionStatus.FAILED) == false) {
             throw new IllegalStateException(