Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored src/core/server/logging,metrics,plugins,rendering,root #90

Merged
merged 8 commits into from
Mar 13, 2021
Merged

[Rename] Refactored src/core/server/logging,metrics,plugins,rendering,root #90

merged 8 commits into from
Mar 13, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #37

Description of changes: Refactored src/core/server/logging,metrics,plugins,rendering,root

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments

src/core/server/root/index.test.mocks.ts Outdated Show resolved Hide resolved
src/core/server/logging/README.md Outdated Show resolved Hide resolved
@kavilla kavilla self-requested a review March 12, 2021 19:24
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni mihirsoni merged commit 1295db4 into opensearch-project:dashboards Mar 13, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
…,root (#90)

* [Rename] addressed PR comments

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
…,root (#90)

* [Rename] addressed PR comments

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
…,root (#90)

* [Rename] addressed PR comments

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Aug 21, 2023
…roject#90)

- register workspace dropdown menu to left menu from workspace plugin
- rename PUBLIC_WORKSPACE and MANAGEMENT_WORKSPACE

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…roject#90)

- register workspace dropdown menu to left menu from workspace plugin
- rename PUBLIC_WORKSPACE and MANAGEMENT_WORKSPACE

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…roject#90)

- register workspace dropdown menu to left menu from workspace plugin
- rename PUBLIC_WORKSPACE and MANAGEMENT_WORKSPACE

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants