Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Adding Missing Snapshot for query_result.test.tsx #8694

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sejli
Copy link
Member

@sejli sejli commented Oct 23, 2024

Description

Adds a missing snapshot from #8565. No need for a backport, the manual backport #8691 includes the change.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Sean Li <lnse@amazon.com>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.84%. Comparing base (e4281e4) to head (05ab47b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8694   +/-   ##
=======================================
  Coverage   60.84%   60.84%           
=======================================
  Files        3793     3793           
  Lines       90486    90486           
  Branches    14212    14212           
=======================================
+ Hits        55055    55057    +2     
+ Misses      31940    31939    -1     
+ Partials     3491     3490    -1     
Flag Coverage Δ
Linux_1 29.07% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.67% <ø> (?)
Linux_4 29.84% <ø> (ø)
Windows_1 29.08% <ø> (ø)
Windows_2 56.35% <ø> (ø)
Windows_3 37.67% <ø> (ø)
Windows_4 29.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh merged commit 9a25d0d into opensearch-project:main Oct 23, 2024
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover for discover reinvent seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants