Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(localization): fixed two localization issues (extraction and plugin build) #869

Closed
wants to merge 1 commit into from
Closed

fix(localization): fixed two localization issues (extraction and plugin build) #869

wants to merge 1 commit into from

Conversation

rios0rios0
Copy link

  • corrected issue when i18n script runs to extract OSD translations
  • corrected plugin localization issue (.i18nrc.json isn't present on .zip built file)

Signed-off-by: Felipe Rios felipe.rios.silva@outlook.com

Description

  1. Solved the extraction issue, adding the literal messages instead of variables and creating a translation folder.
  2. Solved built plugin translation issue, adding the i18rc.json file to the built zip file.

More context on issues.

Issues Resolved

  1. [BUG] issue when i18n script runs to extract OSD translations #867
  2. [BUG] plugin build doesn't include .i18nrc.json required for translations #868

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@rios0rios0
fix(localization): fixed two localization issues (extraction and plug…
2098e54 
…in build)

- corrected issue when i18n script runs to extract OSD translations
- corrected plugin localization issue (`.i18nrc.json` isn't present on `.zip` built file)

Signed-off-by: Felipe Rios <felipe.rios.silva@outlook.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 2098e54

@carloseustaquio
Copy link

Nice! 🎉

This was linked to issues Oct 13, 2021
[BUG] issue when i18n script runs to extract OSD translations #867
Closed
[BUG] plugin build doesn't include .i18nrc.json required for translations #868
Open
@tmarkley tmarkley requested a review from kavilla October 14, 2021 18:27
kavilla
kavilla requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could you fix the tests related to this?

@rios0rios0
Copy link
Author

Thanks for this. Could you fix the tests related to this?

Sure. Give some time, please.

@kavilla
Copy link
Member

kavilla commented Dec 12, 2021

Hello @rios0rios0, this pull request has not had activity recently. We will close this in 7 days if no further updates. If it closes by the time you make the requested updates then please re-open the pull request. Thank you!

@kavilla kavilla closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rios0rios0 @opensearch-ci-bot @carloseustaquio @kavilla