Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [workspace] update search bar layout and align workspace selector #8687

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 79fed30 from #8649.

)

* update search bar layout

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #8649 created/updated

* update search bar layout

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update test case

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* style update

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* typo

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* support search nav items by its parent title

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* address review comments

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 79fed30)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (a0b42c6) to head (cdbbc5d).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...core/public/chrome/ui/header/header_search_bar.tsx 89.47% 3 Missing and 1 partial ⚠️
.../components/global_search/search_pages_command.tsx 42.85% 2 Missing and 2 partials ⚠️
...pace/public/components/global_search/page_item.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8687   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3787     3787           
  Lines       90310    90315    +5     
  Branches    14156    14161    +5     
=======================================
+ Hits        55020    55026    +6     
+ Misses      31818    31816    -2     
- Partials     3472     3473    +1     
Flag Coverage Δ
Linux_1 29.03% <6.38%> (+<0.01%) ⬆️
Linux_2 56.54% <89.47%> (+0.01%) ⬆️
Linux_3 37.71% <0.00%> (+<0.01%) ⬆️
Linux_4 29.94% <0.00%> (+<0.01%) ⬆️
Windows_1 29.04% <6.38%> (+<0.01%) ⬆️
Windows_2 56.50% <89.47%> (+0.01%) ⬆️
Windows_3 37.71% <0.00%> (+<0.01%) ⬆️
Windows_4 29.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit 0433659 into 2.x Oct 23, 2024
69 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-8649-to-2.x branch October 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset v2.18.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants