-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add support for s3 fields in discover #8686
Conversation
* add support for s3 fields in discover Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Changeset file for PR #8609 created/updated * resolve comments, make fields fetch async Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix unit tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update services to be Partial<IDataPluginServices> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix async field fetch in cachedataset Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * resolve comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 12d072d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8686 +/- ##
==========================================
+ Coverage 60.92% 60.93% +0.01%
==========================================
Files 3787 3787
Lines 90303 90352 +49
Branches 14153 14162 +9
==========================================
+ Hits 55015 55054 +39
- Misses 31815 31817 +2
- Partials 3473 3481 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport 12d072d from #8609.