Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add support for s3 fields in discover #8686

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 12d072d from #8609.

* add support for s3 fields in discover

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Changeset file for PR #8609 created/updated

* resolve comments, make fields fetch async

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix unit tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update services to be Partial<IDataPluginServices>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix async field fetch in cachedataset

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* resolve comments

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 12d072d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (426a167) to head (4b74325).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ry/query_string/dataset_service/dataset_service.ts 41.17% 6 Missing and 4 partials ⚠️
...s/data/public/ui/dataset_selector/configurator.tsx 0.00% 4 Missing ⚠️
...gins/query_enhancements/public/datasets/s3_type.ts 90.90% 1 Missing and 2 partials ⚠️
...mon/index_patterns/index_patterns/index_pattern.ts 66.66% 1 Missing ⚠️
...pplication/components/sidebar/discover_sidebar.tsx 0.00% 0 Missing and 1 partial ⚠️
...ication/view_components/utils/use_index_pattern.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8686      +/-   ##
==========================================
+ Coverage   60.92%   60.93%   +0.01%     
==========================================
  Files        3787     3787              
  Lines       90303    90352      +49     
  Branches    14153    14162       +9     
==========================================
+ Hits        55015    55054      +39     
- Misses      31815    31817       +2     
- Partials     3473     3481       +8     
Flag Coverage Δ
Linux_1 29.02% <0.00%> (-0.01%) ⬇️
Linux_2 56.52% <0.00%> (-0.01%) ⬇️
Linux_3 37.71% <34.61%> (-0.01%) ⬇️
Linux_4 29.97% <53.44%> (+0.03%) ⬆️
Windows_1 29.03% <0.00%> (-0.01%) ⬇️
Windows_2 56.47% <0.00%> (-0.01%) ⬇️
Windows_3 37.71% <34.61%> (-0.01%) ⬇️
Windows_4 29.97% <53.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 447d787 into 2.x Oct 23, 2024
69 of 71 checks passed
@github-actions github-actions bot deleted the backport/backport-8609-to-2.x branch October 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants