Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mnaual backport 2.x] Combined #8598, #8651, #8613, #8616, #8659, #8665, #8650, #8668 #8670

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Fix No data selected appearance (#8668)
Also:

  • Fix some React errors

Signed-off-by: Miki miki@amazon.com


Fix random big number during loading in query editor result (#8650)

Signed-off-by: abbyhu2000 abigailhu2000@gmail.com
(cherry picked from commit a7414f0)


[bug] address different issues with dataset selector (#8665)

  • [bug] address some issues with dataset selector

Moved the dataset selector back to the search bar and access it by ref in the sidebar.

Avoid out of sync issue.

  • update the logic for ensuring index pattern
  • dont add ability to open button
  • empty state but missing data set selector button
  • fix tests
  • add back styling

Signed-off-by: Kawika Avilla kavilla414@gmail.com
(cherry picked from commit e23f332)


[bug] Discover UI stuck on searching after deleting index pattern (#8659)

  • [bug] Discover UI stuck on searching after deleting index pattern

When using Discover with query enhancement enabled, deleting an index pattern from Index Management does not properly update the "Recently selected data" list in Discover. This causes the UI to become stuck in a "Searching" state when attempting to use Discover after deleting an index pattern.

Handle the error case where the use index patterns hook caught error when enhancements was enabled.

issue resolved:
#8612

(cherry picked from commit 4808094)


[Discover]Sample Queries and Saved Queries in No Results Page (#8616)

  • Sample Queries and Saved Queries in No Results Page

Signed-off-by: Sean Li lnse@amazon.com
Signed-off-by: Miki miki@amazon.com

Signed-off-by: Miki miki@amazon.com

(cherry picked from commit 9da1b77)


Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View (#8613)

  • Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View

This PR primarily addresses the scenario when no index patterns (general) is available in the Discover view. Instead of redirecting users to the index management page, it introduces a new "No Index Patterns" panel. This panel provides users with the option to open a data selector and add index patterns directly from the Discover view, improving the user experience for new or empty deployments.

To achieve, we move the selectedDataset state from ConnectedDatasetSelector to the app container's state management. This allows the AdvancedSelector, opened from the AppContainer, to update the dataset state effectively. Key changes include:

  • Implementing NoIndexPatternsPanel and AdvancedSelector components.

  • Refactoring dataset state management in AppContainer and Sidebar.

  • Modifying DiscoverCanvas to conditionally render NoIndexPatternsPanel.

  • Updating ConnectedDatasetSelector to use shared state and dataset change handling.

  • Update design of no data selected

  • use i18n

  • fix comments

  • Update design of no data selected

  • fix lint error

Signed-off-by: Anan Zhuang ananzh@amazon.com

(cherry picked from commit 6659139)


Update Discover appearance (#8651)

  • Update Discover appearance

Signed-off-by: Miki miki@amazon.com

(cherry picked from commit 17103ba)


Move DatasetSelector from data plugin queryString comp to DataExplorer (#8598)

  • Move DatasetSelector to DataExplorer
  • Style Disover after moving DatasetSelector to DataExplorer
  • fix the test by adding the getUpdates$ method to the mock queryString object

Signed-off-by: Anan Zhuang ananzh@amazon.com

(cherry picked from commit 923cce8)

Also:
* Fix some React errors

Signed-off-by: Miki <miki@amazon.com>

---------

Fix random big number during loading in query editor result (opensearch-project#8650)

* Fix random big number during loading in query editor result

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Changeset file for PR opensearch-project#8650 created/updated

* Fix initial loading number

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit a7414f0)

---------

[bug] address different issues with dataset selector (opensearch-project#8665)

* [bug] address some issues with dataset selector

Moved the dataset selector back to the search bar and access it by ref in the sidebar.

Avoid out of sync issue.
* update the logic for ensuring index pattern
* dont add ability to open button
* empty state but missing data set selector button
* fix tests
* add back styling

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e23f332)

---------

[bug] Discover UI stuck on searching after deleting index pattern (opensearch-project#8659)

* [bug] Discover UI stuck on searching after deleting index pattern

When using Discover with query enhancement enabled, deleting an index pattern from Index Management does not properly update the "Recently selected data" list in Discover. This causes the UI to become stuck in a "Searching" state when attempting to use
Discover after deleting an index pattern.

Handle the error case where the use index patterns hook caught error when
enhancements was enabled.

issue resolved:
opensearch-project#8612

(cherry picked from commit 4808094)

---------

[Discover]Sample Queries and Saved Queries in No Results Page (opensearch-project#8616)

* Sample Queries and Saved Queries in No Results Page

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8616 created/updated

* Update styling

Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit 9da1b77)

---------

Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View (opensearch-project#8613)

* Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View

This PR primarily addresses the scenario when no index patterns (general) is available in the Discover view.
Instead of redirecting users to the index management page, it introduces a new "No Index Patterns" panel.
This panel provides users with the option to open a data selector and add index patterns
directly from the Discover view, improving the user experience for new or empty deployments.

To achieve, we move the selectedDataset state from ConnectedDatasetSelector to the app container's
state management. This allows the AdvancedSelector, opened from the AppContainer, to update
the dataset state effectively. Key changes include:

* Implementing NoIndexPatternsPanel and AdvancedSelector components.
* Refactoring dataset state management in AppContainer and Sidebar.
* Modifying DiscoverCanvas to conditionally render NoIndexPatternsPanel.
* Updating ConnectedDatasetSelector to use shared state and dataset change handling.

* Update design of no data selected
* use i18n
* fix comments
* Update design of no data selected
* fix lint error

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

(cherry picked from commit 6659139)

---------

Update Discover appearance (opensearch-project#8651)

* Update Discover appearance

Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit 17103ba)

---------

Move DatasetSelector from data plugin queryString comp to DataExplorer (opensearch-project#8598)

* Move DatasetSelector to DataExplorer
* Style Disover after moving DatasetSelector to DataExplorer
* fix the test by adding the getUpdates$ method to the mock queryString object

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

(cherry picked from commit 923cce8)
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 28.30189% with 38 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (bde23d9) to head (9a52cff).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...query_string/language_service/lib/query_result.tsx 15.38% 10 Missing and 1 partial ⚠️
...a/public/ui/dataset_selector/advanced_selector.tsx 0.00% 5 Missing ⚠️
...components/no_index_patterns/no_index_patterns.tsx 20.00% 4 Missing ⚠️
...ta/public/ui/dataset_selector/dataset_selector.tsx 0.00% 3 Missing ⚠️
...rns/index_patterns/ensure_default_index_pattern.ts 33.33% 2 Missing ⚠️
...c/ui/query_editor/editors/default_editor/index.tsx 0.00% 2 Missing ⚠️
...c/application/components/no_results/no_results.tsx 33.33% 2 Missing ⚠️
...ublic/application/view_components/canvas/index.tsx 0.00% 2 Missing ⚠️
...lic/application/view_components/canvas/top_nav.tsx 33.33% 2 Missing ⚠️
...s/data/public/ui/dataset_selector/configurator.tsx 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8670      +/-   ##
==========================================
+ Coverage   60.90%   60.92%   +0.01%     
==========================================
  Files        3787     3787              
  Lines       90341    90297      -44     
  Branches    14167    14152      -15     
==========================================
- Hits        55024    55015       -9     
+ Misses      31847    31810      -37     
- Partials     3470     3472       +2     
Flag Coverage Δ
Linux_1 29.03% <8.88%> (+0.01%) ⬆️
Linux_2 56.53% <0.00%> (-0.01%) ⬇️
Linux_3 37.71% <28.30%> (+0.01%) ⬆️
Linux_4 29.94% <0.00%> (+<0.01%) ⬆️
Windows_1 29.04% <8.88%> (+0.01%) ⬆️
Windows_2 56.48% <0.00%> (-0.01%) ⬇️
Windows_3 37.71% <28.30%> (+0.01%) ⬆️
Windows_4 29.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miki <miki@amazon.com>
@ruanyl ruanyl merged commit 6c33d0d into opensearch-project:2.x Oct 22, 2024
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants