-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Disable confirm button during collaborators operation #8604
Merged
SuZhou-Joe
merged 9 commits into
opensearch-project:main
from
wanglam:add-loading-in-collaborator-actions
Oct 18, 2024
Merged
[Workspace]Disable confirm button during collaborators operation #8604
SuZhou-Joe
merged 9 commits into
opensearch-project:main
from
wanglam:add-loading-in-collaborator-actions
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8604 +/- ##
=======================================
Coverage 60.88% 60.89%
=======================================
Files 3790 3790
Lines 90250 90259 +9
Branches 14151 14152 +1
=======================================
+ Hits 54945 54959 +14
+ Misses 31835 31829 -6
- Partials 3470 3471 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 16, 2024 07:25
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
changed the title
[Workspace]Keep confirm modal and disable confirm button during collaborators operation
[Workspace]Disable confirm button during collaborators operation
Oct 18, 2024
Hailong-am
previously approved these changes
Oct 18, 2024
SuZhou-Joe
previously approved these changes
Oct 18, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
Hailong-am
approved these changes
Oct 18, 2024
SuZhou-Joe
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Keep confirm modal and disable confirm button during operation Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8604 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 896ac00) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 18, 2024
…) (#8653) * Keep confirm modal and disable confirm button during operation * Changeset file for PR #8604 created/updated --------- (cherry picked from commit 896ac00) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2024
…nsearch-project#8604) * Keep confirm modal and disable confirm button during operation Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#8604 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…nsearch-project#8604) * Keep confirm modal and disable confirm button during operation Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#8604 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…nsearch-project#8604) * Keep confirm modal and disable confirm button during operation Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#8604 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the confirm modal was closed after initiating collaborator updates or deletions, allowing users to perform other operations while the API call was in progress. Previously, if changes were made during the API call, the last operation could be missed or overwritten.
To resolve this issue, the following changes have been made:
2. The confirm modal remains open during collaborator updates and deletions, preventing users from performing other operations until the current operation is completed.Done by #8594By keeping the confirm modal open and disabling the confirm button, the user interface now accurately reflects the ongoing operation and prevents potential data loss or inconsistencies caused by concurrent operations.
Screenshot
Testing the changes
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration