Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JSON11 from 1.1.2 to 2.0.0 #8603

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Upgrade JSON11 from 1.1.2 to 2.0.0 to ensure UTF-8 safety when stringifying JSON data.

Issues Resolved

Fixes #7367

Changelog

  • fix: Upgrade JSON11 from 1.1.2 to 2.0.0 to ensure UTF-8 safety when stringifying JSON data

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Miki <miki@amazon.com>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (47ae28b) to head (1f8bfbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8603   +/-   ##
=======================================
  Coverage   60.95%   60.95%           
=======================================
  Files        3790     3790           
  Lines       90296    90296           
  Branches    14151    14151           
=======================================
  Hits        55036    55036           
  Misses      31804    31804           
  Partials     3456     3456           
Flag Coverage Δ
Linux_1 29.29% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.72% <ø> (+<0.01%) ⬆️
Linux_4 29.91% <ø> (ø)
Windows_1 29.31% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.72% <ø> (-0.01%) ⬇️
Windows_4 29.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Miki!

@AMoo-Miki AMoo-Miki merged commit 2f23e1e into opensearch-project:main Oct 16, 2024
72 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 16, 2024
* Upgrade JSON11 from 1.1.2 to 2.0.0

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8603 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2f23e1e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Oct 16, 2024
* Upgrade JSON11 from 1.1.2 to 2.0.0



* Changeset file for PR #8603 created/updated

---------



(cherry picked from commit 2f23e1e)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
* Upgrade JSON11 from 1.1.2 to 2.0.0

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8603 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
* Upgrade JSON11 from 1.1.2 to 2.0.0

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8603 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - OpenSearch Dashboard V2.15.0 - JSON.parse: bad escaped character
3 participants