Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tag parameter in createInternalRepository #8521

Closed
wants to merge 2 commits into from

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Oct 8, 2024

Description

Add a tag parameter to saved_objects's createInternalRepository API. So that customized repository provider may provide different repository based on tag value.

Specify the tag value when usage_collection plugin calls saved_object to create repository.

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (58e1645) to head (e431c59).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8521   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files        3767     3767           
  Lines       89387    89387           
  Branches    13985    13985           
=======================================
  Hits        54471    54471           
  Misses      31519    31519           
  Partials     3397     3397           
Flag Coverage Δ
Linux_1 28.95% <0.00%> (ø)
Linux_2 56.25% <100.00%> (ø)
Linux_3 37.75% <0.00%> (ø)
Linux_4 29.91% <0.00%> (ø)
Windows_1 28.97% <0.00%> (ø)
Windows_2 56.20% <100.00%> (ø)
Windows_3 37.75% <0.00%> (ø)
Windows_4 29.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chishui chishui closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant