chore: Update oui to 1.15 and consume $ouiSideNavBackgroundColor #8480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
❌ Invalid PrefixInvalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
virajsanghvi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
virajsanghvi
requested review from
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8480 +/- ##
==========================================
+ Coverage 60.93% 60.94% +0.01%
==========================================
Files 3760 3760
Lines 89310 89310
Branches 13970 13970
==========================================
+ Hits 54423 54433 +10
+ Misses 31492 31481 -11
- Partials 3395 3396 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Oct 4, 2024
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
SuZhou-Joe
approved these changes
Oct 4, 2024
ruanyl
approved these changes
Oct 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* chore: Update oui to 1.15 and consume $ouiSideNavBackgroundColor Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * Changeset file for PR #8480 created/updated * Add snapshot tests Signed-off-by: Viraj Sanghvi <virajs@amazon.com> --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8fa7ff4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Oct 4, 2024
…) (#8487) * chore: Update oui to 1.15 and consume $ouiSideNavBackgroundColor * Changeset file for PR #8480 created/updated * Add snapshot tests --------- (cherry picked from commit 8fa7ff4) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates oui to 1.15 + updates side nav background color to use official oui variable
Issues Resolved
N/A
Screenshot
Testing the changes
Validated changes picked up
Changelog
Check List
yarn test:jestyarn test:jest_integration