Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] De-Couple Dashboards linux building process #843

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 5, 2021

When running yarn build --skip-os-packages it will build 4 tarballs
for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to
do so.

In this PR, we break the building process to allow single linux to
build. If run yarn build-platform --linux-x64 only linux x64 tarball
is created. Same for linux arm64 and darwin x64. You could run yarn build-platform --linux-arm64 and yarn build-platform darwin-x64.

partially solved:
#473

backport PR:
#795

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

When running yarn build --skip-os-packages it will build 4 tarballs
for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to
do so.

In this PR, we break the building process to allow single linux to
build. If run `yarn build-platform --linux-x64` only linux x64 tarball
is created. Same for linux arm64 and darwin x64. You could run `yarn
build-platform --linux-arm64` and `yarn build-platform darwin-x64`.

partially solved:
opensearch-project#473

backport PR:
opensearch-project#795

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added build Build related additions or modifications v1.1.0 backlog Issues that the Dashboards core team is interested in pursuing but are not yet on the roadmap labels Oct 5, 2021
@ananzh ananzh self-assigned this Oct 5, 2021
@ananzh ananzh added backport and removed backlog Issues that the Dashboards core team is interested in pursuing but are not yet on the roadmap labels Oct 5, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 9cdc60f

@ananzh ananzh merged commit 0cf190e into opensearch-project:1.1 Oct 5, 2021
@ananzh ananzh deleted the 1.1_decouple branch October 6, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related additions or modifications v1.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants