[Worksapce] Hide delete button for non osd admins in workspace list #8315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Hailong-am
reviewed
Sep 24, 2024
Comment on lines
+320
to
333
| isDashboardAdmin && ( | ||
| <> | ||
| <EuiButton color="danger" iconType="trash" onClick={onClick}> | ||
| Delete {selection.length} Workspace | ||
| </EuiButton> | ||
| {deletedWorkspaces && deletedWorkspaces.length > 0 && ( | ||
| <DeleteWorkspaceModal | ||
| selectedWorkspaces={deletedWorkspaces} | ||
| onClose={() => setDeletedWorkspaces([])} | ||
| /> | ||
| )} | ||
| </> | ||
| ) | ||
| ); |
There was a problem hiding this comment.
should we hide the checkbox as well? the only action user can take for multiple select is batch delete, if we hide the delete button and keep multi select, that looks a little wired user can't do anything after select.
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
ruanyl
approved these changes
Sep 29, 2024
SuZhou-Joe
approved these changes
Sep 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8315 +/- ##
==========================================
- Coverage 64.14% 60.98% -3.17%
==========================================
Files 3743 3743
Lines 88836 88845 +9
Branches 13852 13857 +5
==========================================
- Hits 56981 54179 -2802
- Misses 31240 31312 +72
- Partials 615 3354 +2739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
…8315) * hide delete_workspace button for non osd admins in workspace list Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #8315 created/updated * Disable selection of workspaces for non osd admins Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8fb8fed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 30, 2024
…8315) (#8376) * hide delete_workspace button for non osd admins in workspace list * Changeset file for PR #8315 created/updated * Disable selection of workspaces for non osd admins --------- (cherry picked from commit 8fb8fed) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…pensearch-project#8315) (opensearch-project#8376) * hide delete_workspace button for non osd admins in workspace list * Changeset file for PR opensearch-project#8315 created/updated * Disable selection of workspaces for non osd admins --------- (cherry picked from commit 8fb8fed) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide delete button for non osd admins in workspace list
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration