[Workspace] Address UI issues of index patterns #8287
Conversation
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…ot bold Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…ot bold Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…e-filters panel Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
Kapian1234
requested review from
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8287 +/- ##
==========================================
+ Coverage 64.05% 64.14% +0.08%
==========================================
Files 3741 3743 +2
Lines 88683 88833 +150
Branches 13817 13852 +35
==========================================
+ Hits 56809 56980 +171
+ Misses 31262 31238 -24
- Partials 612 615 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…OpenSearch-Dashboards into workspace_index_patterns_fix
| @@ -183,7 +183,7 @@ export function Tabs({ indexPattern, saveIndexPattern, fields, history, location | |||
| return ( | |||
| <> | |||
| {useUpdatedUX && <EuiSpacer size="m" />} | |||
| <Wrapper> | |||
| <Wrapper paddingSize="m"> | |||
There was a problem hiding this comment.
Do we need to take useUpdatedUX into consideration? Here we will have 2x paddingM vertically if useUpdatedUX is true.
There was a problem hiding this comment.
Sorry I'm not quite clear on how useUpdatedUX leads to 2x paddingM, but I see it work as expected when useUpdatedUX is true
|
@Kapian1234 Can you post the screenshot when useUpdatedUX is false? |
SuZhou-Joe
added
workspace
look & feel
…ch-Dashboards into workspace_index_patterns_fix
|
Description
Adjust the padding of index-pattern list panel to 16px.
Make the Pattern column bold, and the Data-source-connection column not bold
Ajust the spacing within the index-pattern detail panel to 16px
Add plusInCircle icon to the Add-scripted-field button
Ajust the space between the search bar and the button to 8px at Source-filters panel
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration