chore(dev-deps): upgrade Sinon to v18 #8285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…tual one Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
github-actions
bot
added
Skip-Changelog
AMoo-Miki
reviewed
Oct 4, 2024
| @@ -15981,7 +15988,7 @@ string-similarity@^4.0.1: | |||
| resolved "https://registry.yarnpkg.com/string-similarity/-/string-similarity-4.0.4.tgz#42d01ab0b34660ea8a018da8f56a3309bb8b2a5b" | |||
| integrity sha512-/q/8Q4Bl4ZKAPjj8WerIBJWALKkaPRfrvhfF8k/B23i4nzrlRj2/go1m90In7nG/3XDSbOo0+pu6RvCTM9RGMQ== | |||
|
|
|||
| "string-width-cjs@npm:string-width@^4.2.0": | |||
| "string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3: | |||
There was a problem hiding this comment.
Can you plz undo these unrelated changes?
There was a problem hiding this comment.
I tried to revert these but it got restored after running yarn
I'm using Node v18 and Yarn v1.22.21, btw
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8285 +/- ##
==========================================
- Coverage 64.14% 60.97% -3.17%
==========================================
Files 3743 3743
Lines 88833 88833
Branches 13852 13852
==========================================
- Hits 56979 54170 -2809
- Misses 31239 31309 +70
- Partials 615 3354 +2739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade dev dep
Sinonto v18, rectify path for ESLint script and fix a flaky unit testIssues Resolved
N/A
Screenshot
N/A
Testing the changes
CI jobs should be green
Changelog
Check List
yarn test:jestyarn test:jest_integration