-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix workspace assets page UI bugs #8265
[Workspace]Fix workspace assets page UI bugs #8265
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8265 +/- ##
==========================================
- Coverage 60.92% 60.92% -0.01%
==========================================
Files 3749 3749
Lines 89021 89033 +12
Branches 13899 13903 +4
==========================================
+ Hits 54236 54240 +4
- Misses 31423 31430 +7
- Partials 3362 3363 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
label: i18n.translate( | ||
'savedObjectsManagement.objectsTable.header.exportAssetsButtonLabel', | ||
{ | ||
defaultMessage: 'Export all assets', | ||
} | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to check new home page flag for all those wording change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new home page flag check logic is already in line 121. I think we don't need to do it again here. This export button only displayed when new home page flag enabled.
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* Update the gap between search bar and table Signed-off-by: Lin Wang <wonglam@amazon.com> * Update to target workspace and remove description Signed-off-by: Lin Wang <wonglam@amazon.com> * Add bottom Close button for copy result flyout Signed-off-by: Lin Wang <wonglam@amazon.com> * Update "Objects" to "Assets" in the export modal Signed-off-by: Lin Wang <wonglam@amazon.com> * Hide workspace column and filter when in a workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * Add tooltip for table refresh button Signed-off-by: Lin Wang <wonglam@amazon.com> * Update objects to assets in top right buttons Signed-off-by: Lin Wang <wonglam@amazon.com> * Update objects to assets in flyout Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8265 created/updated * Reduce page content padding for new updated UX Signed-off-by: Lin Wang <wonglam@amazon.com> * Update meta title Signed-off-by: Lin Wang <wonglam@amazon.com> * Update object to asset Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3ef1e09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update the gap between search bar and table * Update to target workspace and remove description * Add bottom Close button for copy result flyout * Update "Objects" to "Assets" in the export modal * Hide workspace column and filter when in a workspace * Add tooltip for table refresh button * Update objects to assets in top right buttons * Update objects to assets in flyout * Changeset file for PR #8265 created/updated * Reduce page content padding for new updated UX * Update meta title * Update object to asset --------- (cherry picked from commit 3ef1e09) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-project#8378) * Update the gap between search bar and table * Update to target workspace and remove description * Add bottom Close button for copy result flyout * Update "Objects" to "Assets" in the export modal * Hide workspace column and filter when in a workspace * Add tooltip for table refresh button * Update objects to assets in top right buttons * Update objects to assets in flyout * Changeset file for PR opensearch-project#8265 created/updated * Reduce page content padding for new updated UX * Update meta title * Update object to asset --------- (cherry picked from commit 3ef1e09) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR is for fixing a bunch of UI bugs in the workspace assets page. Here are the fixed list:
Issues Resolved
Screenshot
Global assets
Workspace assets
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration