-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data explorer ui to use compressed components #8222
Merged
ashwin-pc
merged 5 commits into
opensearch-project:main
from
ps48:discover-compressed-ux
Sep 25, 2024
Merged
Update data explorer ui to use compressed components #8222
ashwin-pc
merged 5 commits into
opensearch-project:main
from
ps48:discover-compressed-ux
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
September 18, 2024 16:18
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8222 +/- ##
=======================================
Coverage 64.05% 64.05%
=======================================
Files 3741 3741
Lines 88629 88633 +4
Branches 13801 13804 +3
=======================================
+ Hits 56771 56775 +4
Misses 31260 31260
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
AMoo-Miki
approved these changes
Sep 19, 2024
#8204 should merged before this. |
joshuali925
approved these changes
Sep 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* update discover ui to use compressed components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert query editor changes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Changeset file for PR #8222 created/updated * update overflow prop for query editor Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update language selector snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8d45530) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* update discover ui to use compressed components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert query editor changes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Changeset file for PR #8222 created/updated * update overflow prop for query editor Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update language selector snapshots Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8d45530) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
Sep 30, 2024
* update discover ui to use compressed components * revert query editor changes * Changeset file for PR #8222 created/updated * update overflow prop for query editor * update language selector snapshots --------- (cherry picked from commit 8d45530) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…ect#8222) (opensearch-project#8343) * update discover ui to use compressed components * revert query editor changes * Changeset file for PR opensearch-project#8222 created/updated * update overflow prop for query editor * update language selector snapshots --------- (cherry picked from commit 8d45530) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Data explorer with query enhancements enabled:
Data explorer with query enhancements disabled:
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration