Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x] [navigation] Add workspace icon to left nav / workspace picker menu / home page. (#7823) #7995

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[Manual backport 2.x] [navigation] Add workspace icon to left nav / workspace picker menu / home page. (#7823) #7995

merged 1 commit into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Sep 4, 2024 •
edited by SuZhou-Joe
Loading

Backport 1974ca1 from #7823.

@github-actions @opensearch-changeset-bot @wanglam
[navigation] Add workspace icon to left nav / workspace picker menu /…
6aa56e0 
… home page. (#7823) (#7994)

* feat: show workspace picker content in left nav

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: finish picker content

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: only register index patterns to settings and setup when workspace is disabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: put discover 2.0 behind discover

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add coverage

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: improve test coverage

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: merge conflict

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code based on comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize filter code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add new icon to left navigation and workspace picker menu

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change use case card in home

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize alignment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7823 created/updated

* feat: alignment optimize

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use new icons in workspace picker

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize color

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: increase test coverage

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Add workspace icon in workspace creator (#19)

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: fatal error when visibleUseCases is empty

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
(cherry picked from commit 1974ca1)
(cherry picked from commit cbdb0fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added the autocut Skip the changelog verification check on backports label Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@SuZhou-Joe SuZhou-Joe changed the title [Backport 2.x] [navigation] Add workspace icon to left nav / workspace picker menu / home page. (#7823) [Manual backport 2.x] [navigation] Add workspace icon to left nav / workspace picker menu / home page. (#7823) Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.15%. Comparing base (624c692) to head (6aa56e0).
Report is 17 commits behind head on 2.x.

Files with missing lines Patch % Lines
...me/ui/header/collapsible_nav_group_enabled_top.tsx 78.57% 0 Missing and 3 partials ⚠️
...nents/home_get_start_card/setup_get_start_card.tsx 0.00% 2 Missing ⚠️
...ic/components/use_case_overview/setup_overview.tsx 0.00% 2 Missing ⚠️
...ublic/components/workspace_menu/workspace_menu.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #7995   +/-   ##
=======================================
  Coverage   61.15%   61.15%           
=======================================
  Files        3689     3689           
  Lines       87201    87212   +11     
  Branches    13396    13402    +6     
=======================================
+ Hits        53326    53334    +8     
- Misses      30636    30637    +1     
- Partials     3239     3241    +2
Flag Coverage Δ
Linux_1 29.23% <20.83%> (-0.01%) ⬇️
Linux_2 56.36% <78.57%> (+<0.01%) ⬆️
Linux_3 37.97% <12.50%> (-0.01%) ⬇️
Linux_4 29.69% <12.50%> (-0.01%) ⬇️
Windows_1 29.24% <20.83%> (-0.01%) ⬇️
Windows_2 56.31% <78.57%> (+<0.01%) ⬆️
Windows_3 37.97% <12.50%> (-0.01%) ⬇️
Windows_4 29.69% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 4c64d81 into 2.x Sep 5, 2024
67 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
@github-actions @opensearch-changeset-bot @wanglam
[navigation] Add workspace icon to left nav / workspace picker menu /…
915275a 
… home page. (#7823) (#7994) (#7995)

* feat: show workspace picker content in left nav

* fix: bootstrap error

* fix: unit test error

* feat: finish picker content

* feat: finish picker content

* feat: only register index patterns to settings and setup when workspace is disabled

* fix: unit test

* feat: put discover 2.0 behind discover

* feat: add coverage

* feat: improve test coverage

* feat: merge conflict

* feat: optimize code based on comment

* feat: optimize code based on comment

* feat: optimize filter code

* feat: update

* feat: add new icon to left navigation and workspace picker menu

* feat: change use case card in home

* feat: optimize alignment

* Changeset file for PR #7823 created/updated

* feat: alignment optimize

* feat: use new icons in workspace picker

* feat: optimize color

* fix: unit test error

* fix: unit test

* fix: unit test

* feat: increase test coverage

* feat: remove useless code

* Add workspace icon in workspace creator (#19)

* fix: fatal error when visibleUseCases is empty

---------

(cherry picked from commit 1974ca1)
(cherry picked from commit cbdb0fd)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
(cherry picked from commit 4c64d81)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 6, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @wanglam
[navigation] Add workspace icon to left nav / workspace picker menu /…
0134eb6 
… home page. (#7823) (#7994) (#7995) (#8038)

* feat: show workspace picker content in left nav

* fix: bootstrap error

* fix: unit test error

* feat: finish picker content

* feat: finish picker content

* feat: only register index patterns to settings and setup when workspace is disabled

* fix: unit test

* feat: put discover 2.0 behind discover

* feat: add coverage

* feat: improve test coverage

* feat: merge conflict

* feat: optimize code based on comment

* feat: optimize code based on comment

* feat: optimize filter code

* feat: update

* feat: add new icon to left navigation and workspace picker menu

* feat: change use case card in home

* feat: optimize alignment

* Changeset file for PR #7823 created/updated

* feat: alignment optimize

* feat: use new icons in workspace picker

* feat: optimize color

* fix: unit test error

* fix: unit test

* fix: unit test

* feat: increase test coverage

* feat: remove useless code

* Add workspace icon in workspace creator (#19)

* fix: fatal error when visibleUseCases is empty

---------

(cherry picked from commit 1974ca1)
(cherry picked from commit cbdb0fd)







(cherry picked from commit 4c64d81)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports backport 2.17 failed changeset v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruanyl @SuZhou-Joe