Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]refactor style of workspace picker content #7764

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Aug 20, 2024

Description

In this pr, I refractor the style of workspace picker content by applying searching and filtering. This pr is developed based on #7716

Screenshot

  1. appearance
    out of a workspace
Screenshot 2024-08-19 at 16 38 24

In a workspace

Screenshot 2024-08-19 at 16 38 47
  1. Perform searching and filtering, result will be shown in both recent and all section
Screenshot 2024-08-19 at 16 38 57
  1. empty state
Screenshot 2024-08-19 at 16 57 15 Screenshot 2024-08-19 at 16 39 01

Changelog

  • feat: refractor style of workspace picker content

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 76.87861% with 40 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (9aeebec) to head (60089b3).

Files Patch % Lines
...kspace_picker_content/workspace_picker_content.tsx 70.58% 11 Missing and 4 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 79.59% 3 Missing and 7 partials ⚠️
...public/chrome/ui/header/collapsible_nav_groups.tsx 87.09% 1 Missing and 3 partials ⚠️
...ublic/components/workspace_menu/workspace_menu.tsx 76.92% 1 Missing and 2 partials ⚠️
src/plugins/workspace/public/plugin.ts 40.00% 3 Missing ⚠️
.../core/public/chrome/nav_group/nav_group_service.ts 85.71% 1 Missing and 1 partial ⚠️
src/core/public/chrome/ui/header/header.tsx 0.00% 0 Missing and 2 partials ⚠️
.../plugins/index_pattern_management/public/plugin.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7764      +/-   ##
==========================================
- Coverage   63.82%   63.81%   -0.01%     
==========================================
  Files        3655     3657       +2     
  Lines       81117    81181      +64     
  Branches    12921    12940      +19     
==========================================
+ Hits        51772    51805      +33     
- Misses      26167    26187      +20     
- Partials     3178     3189      +11     
Flag Coverage Δ
Linux_2 55.87% <82.17%> (+<0.01%) ⬆️
Linux_3 40.41% <3.84%> (-0.03%) ⬇️
Linux_4 31.28% <5.76%> (-0.02%) ⬇️
Windows_1 30.10% <30.58%> (+<0.01%) ⬆️
Windows_2 55.82% <82.17%> (+<0.01%) ⬆️
Windows_3 40.41% <3.84%> (-0.02%) ⬇️
Windows_4 31.28% <5.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 20, 2024
@Qxisylolo Qxisylolo force-pushed the feature/adjust-style-of-workspace-picker-content branch from ba4a298 to 5092207 Compare August 20, 2024 06:49
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…ce is disabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 22, 2024
@Qxisylolo Qxisylolo force-pushed the feature/adjust-style-of-workspace-picker-content branch from 60089b3 to 629e2dd Compare August 22, 2024 10:05
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Qxisylolo and others added 9 commits August 28, 2024 14:39
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo Qxisylolo force-pushed the feature/adjust-style-of-workspace-picker-content branch from 629e2dd to d011fc0 Compare August 28, 2024 07:46
@Hailong-am
Copy link
Collaborator

when i login in as non OSD admin and don't have any workspace available, it display like this, should we limit the width of the picker?
image

@Qxisylolo Qxisylolo changed the title [Workspace]refractor style of workspace picker content [Workspace]refactor style of workspace picker content Sep 29, 2024
@ruanyl ruanyl closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants