Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Add workspaces and permissions fields into saved objects _bulk_get response #7565

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[Workspace]Add workspaces and permissions fields into saved objects _bulk_get response #7565

merged 3 commits into from
Jul 30, 2024

Conversation

Hailong-am
Copy link
Collaborator

Description

this PR will add workspaces and permissions fields into saved objects _bulk_get response

Issues Resolved

#7564

Screenshot

Testing the changes

Changelog

  • fix: [Workspace]Add workspaces and permissions fields into saved objects _bulk_get response

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Hailong-am
fix missing fields
9df534c 
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (d68c589) to head (f832063).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7565   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        3629     3629           
  Lines       79522    79522           
  Branches    12604    12604           
=======================================
  Hits        50611    50611           
  Misses      25842    25842           
  Partials     3069     3069
Flag Coverage Δ
Linux_1 30.76% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.22% <ø> (ø)
Linux_4 31.57% <ø> (ø)
Windows_1 30.77% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.23% <ø> (ø)
Windows_4 31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

@SuZhou-Joe SuZhou-Joe merged commit f3dee46 into opensearch-project:main Jul 30, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
@github-actions @opensearch-changeset-bot
[Workspace]Add workspaces and permissions fields into saved objects _…
55ebb7b 
…bulk_get response (#7565)

* fix missing fields

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #7565 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f3dee46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 30, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
@github-actions @opensearch-changeset-bot
[Workspace]Add workspaces and permissions fields into saved objects _…
2dd743e 
…bulk_get response (#7565)

* fix missing fields

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #7565 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f3dee46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 30, 2024
Closed
ananzh pushed a commit that referenced this pull request Jul 30, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace]Add workspaces and permissions fields into saved objects _…
f2eaa6e 
…bulk_get response (#7565) (#7569)

* fix missing fields
* Changeset file for PR #7565 created/updated

---------



(cherry picked from commit f3dee46)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
@Hailong-am @opensearch-changeset-bot @Qxisylolo
[Workspace]Add workspaces and permissions fields into saved objects _…
be6da53 
…bulk_get response (opensearch-project#7565)

* fix missing fields

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR opensearch-project#7565 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 seasoned-contributor v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hailong-am @ruanyl @SuZhou-Joe