Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Suggest] Add back reverted MDS support, tests and cleanup for sql auto suggest #7543

Merged

Commits on Jul 29, 2024

  1. add max heigh. use memoization

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    almost working pretty nicely
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    a  little bit better
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    its ok
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    3efaa55 View commit details
    Browse the repository at this point in the history
  2. update mock

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f230a23 View commit details
    Browse the repository at this point in the history
  3. update another mock

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b5e628f View commit details
    Browse the repository at this point in the history
  4. fix mock for extension

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4f72440 View commit details
    Browse the repository at this point in the history
  5. rebase fixes

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    aadbe4d View commit details
    Browse the repository at this point in the history
  6. update script

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e47af9c View commit details
    Browse the repository at this point in the history
  7. fix initial load

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    335978d View commit details
    Browse the repository at this point in the history
  8. [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (op…

    …ensearch-project#7463)
    
    * add tests for sql autocomplete rule processing
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * refer to monaco type directly
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * remove unnecessary antlr auto generated files
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * inital adoption of dataSet manager
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * mds support
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * remove test that are failed due to adopting dataSet manager
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * add changelog
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * fix(query assist): update reading data source id from dataset manager (opensearch-project#7464)
    
    * revert to read datasource id from index pattern
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    * add dataset mock to query mock
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    * update query assist to use dataset manager
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    * use selected dataset state instead of relying on rerender
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    * remove skip 1 in dataset observable
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    * update dataset_manager tests
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    ---------
    
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    
    * update utils
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * keep with observable and remove values suggestion
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * update unit tests
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * [Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467)
    
    * Antlr autocomplete (opensearch-project#7159)
    
    * dql grammar with rudamentary testing parser
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * show suggestion of fields depending on current index pattern
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * basic code completion with fields populated
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * updated grammar and generated for better group handling
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * add ignored tokens
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * remove console logs
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    ---------
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * dql Antlr autocomplete (opensearch-project#7160)
    
    * re-add provider for sql
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * added temporary fix for language providor to appear for more than one language
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    ---------
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * remove EOF in parser to fix suggestions
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * use custom version of cursor token index for dql
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * implemented value suggestions based on field
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * set param type
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * update grouping grammar
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * fix grammar for dots in field and value term search with spaces
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * value suggestions match field to avoid failing api call and to find assc keyword field
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * update value suggestions from partially formed value
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * refactor value suggestions and change fieldval listener to visitor
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * implement value suggestions within phrases
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * make grammar more readable
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * rename grammar parser rules
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * bring back minimal autocomplete optimized grammar
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * enable partially complete value suggestion for value groups
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * remove number as lexer rule
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * fix cursor import and clean up
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * fix completion item range to be current word
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * update cursor to use monaco position
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * cursor index to use position directly
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * move language registration into render function to handle new languages
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * include auto closing quotes and parenthesis for dql
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * rename generated file
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * include single line editor closing pairs
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * Changeset file for PR opensearch-project#7391 created/updated
    
    * add license and fix linting
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * modify grammar
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * add tests for fields and keywords
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * move dql test constants to separate file
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * update an import
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * use updated dataset for index pattern
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    * remove console log
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    
    ---------
    
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    
    * [tests][discover-next] update the tests and async nature of the dataset navigator (opensearch-project#7489)
    
    * [tests][discover-next] update the tests and async nature of the dataset manager
    
    Address test failures related to the dataset navigator.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    * bad fingers accidentally hit the x button
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    ---------
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    * resolve conflicts
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    * fix one minor linting
    
    Signed-off-by: Eric <menwe@amazon.com>
    
    ---------
    
    Signed-off-by: Eric <menwe@amazon.com>
    Signed-off-by: Joshua Li <joshuali925@gmail.com>
    Signed-off-by: Paul Sebastian <paulstn@amazon.com>
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    Signed-off-by: Eric Wei <menwe@amazon.com>
    Co-authored-by: Joshua Li <joshuali925@gmail.com>
    Co-authored-by: Paul Sebastian <paulstn@amazon.com>
    Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
    Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
    Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
    6 people committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    47bfae9 View commit details
    Browse the repository at this point in the history
  9. update snapshot

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    14841ef View commit details
    Browse the repository at this point in the history
  10. add back required dependency and minor clean up

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d3223af View commit details
    Browse the repository at this point in the history
  11. minor clean up

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    70f238c View commit details
    Browse the repository at this point in the history
  12. support with skip(1)

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9a34528 View commit details
    Browse the repository at this point in the history
  13. add back sql auto suggest

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e55c76a View commit details
    Browse the repository at this point in the history
  14. add back disabling of wordBasedSuggestions

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7625412 View commit details
    Browse the repository at this point in the history
  15. update tests

    Signed-off-by: Eric <menwe@amazon.com>
    mengweieric committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f2d381f View commit details
    Browse the repository at this point in the history
  16. Merge branch 'main' into feature/add-reverted-sql-ausuggest

    Signed-off-by: Eric Wei <menwe@amazon.com>
    mengweieric authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9e7b1be View commit details
    Browse the repository at this point in the history