Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [discover-next][bug] add back data set navigator to control state #7532

Merged
merged 2 commits into from
Jul 29, 2024

Merge branch '2.x' into backport/backport-7492-to-2.x

d4ff45e
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] [discover-next][bug] add back data set navigator to control state #7532

Merge branch '2.x' into backport/backport-7492-to-2.x
d4ff45e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 29, 2024 in 0s

63.75% (-0.46%) compared to bcb8355

View this Pull Request on Codecov

63.75% (-0.46%) compared to bcb8355

Details

Codecov Report

Attention: Patch coverage is 24.60317% with 665 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (bcb8355) to head (d4ff45e).

Files Patch % Lines
.../public/ui/dataset_navigator/dataset_navigator.tsx 0.57% 174 Missing ⚠️
...taset_navigator/lib/catalog_cache/cache_loader.tsx 8.10% 136 Missing ⚠️
...taset_navigator/lib/catalog_cache/cache_manager.ts 3.93% 122 Missing ⚠️
...blic/ui/dataset_navigator/lib/utils/use_polling.ts 0.00% 57 Missing ⚠️
.../public/query/state_sync/connect_to_query_state.ts 28.57% 14 Missing and 6 partials ⚠️
...ta/public/ui/dataset_navigator/lib/requests/sql.ts 0.00% 18 Missing ⚠️
src/plugins/data/public/search/search_service.ts 0.00% 14 Missing ⚠️
...ta/public/ui/dataset_navigator/lib/utils/shared.ts 88.23% 14 Missing ⚠️
src/plugins/data/common/data_frames/utils.ts 0.00% 11 Missing ⚠️
...navigator/lib/utils/fetch_external_data_sources.ts 15.38% 11 Missing ⚠️
... and 23 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7532      +/-   ##
==========================================
- Coverage   64.21%   63.75%   -0.46%     
==========================================
  Files        3614     3628      +14     
  Lines       78750    79488     +738     
  Branches    12446    12587     +141     
==========================================
+ Hits        50569    50681     +112     
- Misses      25131    25746     +615     
- Partials     3050     3061      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov