[Workspace]Optimize workspace permission validation for bulk operations #7516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
wanglam
force-pushed
the
optimize-workspace-permission-validation
branch
from
5c62c6b to
a6521a2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7516 +/- ##
==========================================
+ Coverage 63.65% 63.67% +0.01%
==========================================
Files 3632 3632
Lines 80060 80101 +41
Branches 12683 12691 +8
==========================================
+ Hits 50965 51004 +39
Misses 25990 25990
- Partials 3105 3107 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
force-pushed
the
optimize-workspace-permission-validation
branch
from
a6521a2 to
e8b4b17
Compare
wanglam
changed the title
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
force-pushed
the
optimize-workspace-permission-validation
branch
from
98d108d to
cc91fd4
Compare
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
ruanyl
reviewed
Jul 29, 2024
| this._savedObjectCache.delete(requestKey); | ||
| } | ||
|
|
||
| public isSavedObjectsCacheActive(request: OpenSearchDashboardsRequest) { |
There was a problem hiding this comment.
Do we need to call isSavedObjectsCacheActive before clearSavedObjectsCache? Seems it can call clearSavedObjectsCache directly.
There was a problem hiding this comment.
Sure, since this delete operation will be fired in every request response. Not sure if it too expensive to do the delete.
There was a problem hiding this comment.
We can encapsulate the check in clearSavedObjectsCache
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
reviewed
Jul 30, 2024
SuZhou-Joe
reviewed
Jul 30, 2024
SuZhou-Joe
reviewed
Jul 30, 2024
Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
approved these changes
Aug 5, 2024
ruanyl
approved these changes
Aug 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
…ns (#7516) * Optimize workspace permission validation for bulk operations Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7516 created/updated * Remove isSavedObjectsCacheActive in permission control client Signed-off-by: Lin Wang <wonglam@amazon.com> * Update src/plugins/workspace/server/permission_control/client.ts Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> * Rename cacheSavedObjects to addToCacheAllowlist Signed-off-by: Lin Wang <wonglam@amazon.com> * Use request uuid as cache Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit ef47b5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Aug 9, 2024
…ns (#7516) (#7660) * Optimize workspace permission validation for bulk operations * Changeset file for PR #7516 created/updated * Remove isSavedObjectsCacheActive in permission control client * Update src/plugins/workspace/server/permission_control/client.ts * Rename cacheSavedObjects to addToCacheAllowlist * Use request uuid as cache --------- (cherry picked from commit ef47b5f) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for optimizing saved objects's workspace permission validation logic for bulk operations. It mainly includes below three changes:
Issues Resolved
#7520
Screenshot
No UI Changes
Testing the changes
Can refer test files:
Changelog
Check List
yarn test:jestyarn test:jest_integration