Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation-next] Fix issues. #7356

Merged
merged 7 commits into from
Jul 23, 2024
Merged

[navigation-next] Fix issues. #7356

merged 7 commits into from
Jul 23, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jul 22, 2024 •
edited
Loading

Description

This PR fix the issues:

  • Always collapse the new left navigation in home page when workspace is enabled.
  • Typo fix in all use case description.
  • declare advanced_settings, dev_tools, data_administration_landing, settings_and_setup_landing pages as features not visible within workspace.
  • Remove the useless flushLeft in workspace picker as it will have a margin style.
  • Show overview page in workspace of type of all and hide home.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: [navigation-next] Fix issues.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

SuZhou-Joe and others added 2 commits July 21, 2024 17:24
@SuZhou-Joe @opensearch-changeset-bot
[navigation-next] fix: redirect to standard index pattern application…
2c708e3 
…s while nav group is enabled (opensearch-project#7305)

* feat: fix the incorrect jumping logic for Index pattern management

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7305 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update with comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update order and remove reset logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some category change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update category

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@SuZhou-Joe
fix: bugs found in integration test
7e4bc55 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
Merge branch 'feature/navigation-next' into fix/integration-bug
850bd08 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/navigation-next branch from 2c708e3 to e64de15 Compare July 22, 2024 06:40
@SuZhou-Joe SuZhou-Joe marked this pull request as draft July 22, 2024 06:49
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (e64de15) to head (3cba896).

Files Patch % Lines
src/plugins/workspace/public/plugin.ts 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feature/navigation-next    #7356   +/-   ##
========================================================
  Coverage                    67.70%   67.70%           
========================================================
  Files                         3520     3520           
  Lines                        69700    69707    +7     
  Branches                     11376    11379    +3     
========================================================
+ Hits                         47189    47194    +5     
- Misses                       19716    19717    +1     
- Partials                      2795     2796    +1
Flag Coverage Δ
Linux_1 33.18% <33.33%> (+<0.01%) ⬆️
Linux_2 55.46% <100.00%> (+<0.01%) ⬆️
Linux_3 43.31% <0.00%> (-0.01%) ⬇️
Linux_4 34.70% <0.00%> (-0.01%) ⬇️
Windows_1 33.20% <33.33%> (+<0.01%) ⬆️
Windows_2 55.41% <100.00%> (+<0.01%) ⬆️
Windows_3 43.32% <0.00%> (-0.01%) ⬇️
Windows_4 34.70% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
feat: show workspace detail in all use case
33eb925 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
fix: unit test error
2ff9a57 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: revert back detect category
3cba896 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review July 23, 2024 00:07
@SuZhou-Joe SuZhou-Joe merged commit 8b46c44 into opensearch-project:feature/navigation-next Jul 23, 2024
66 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions @opensearch-changeset-bot
[navigation-next] Fix issues. (#7356)
1e843d9 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7305 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update with comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update order and remove reset logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some category change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update category

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* fix: bugs found in integration test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert back detect category

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8b46c44)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Merged
5 tasks
SuZhou-Joe pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[navigation-next] Fix issues. (#7356) (#7377)
6551af7 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management



* Changeset file for PR #7305 created/updated

* feat: update



* feat: update with comment



* feat: update order and remove reset logic



* feat: update



* feat: update



* feat: update snapshot



* feat: some category change



* feat: update category



---------




* fix: bugs found in integration test



* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case



* fix: unit test error



* feat: revert back detect category



---------



(cherry picked from commit 8b46c44)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @SuZhou-Joe
[navigation-next] Fix issues. (opensearch-project#7356) (opensearch-p…
8478979 
…roject#7377)

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (opensearch-project#7305)

* feat: fix the incorrect jumping logic for Index pattern management

* Changeset file for PR opensearch-project#7305 created/updated

* feat: update

* feat: update with comment

* feat: update order and remove reset logic

* feat: update

* feat: update

* feat: update snapshot

* feat: some category change

* feat: update category

---------

* fix: bugs found in integration test

* Changeset file for PR opensearch-project#7356 created/updated

* feat: show workspace detail in all use case

* fix: unit test error

* feat: revert back detect category

---------

(cherry picked from commit 8b46c44)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6551af7)
SuZhou-Joe added a commit that referenced this pull request Jul 23, 2024
@SuZhou-Joe @opensearch-trigger-bot
[navigation-next] Fix issues. (#7356) (#7377) (#7379)
7adc980 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

* Changeset file for PR #7305 created/updated

* feat: update

* feat: update with comment

* feat: update order and remove reset logic

* feat: update

* feat: update

* feat: update snapshot

* feat: some category change

* feat: update category

---------

* fix: bugs found in integration test

* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case

* fix: unit test error

* feat: revert back detect category

---------

(cherry picked from commit 8b46c44)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6551af7)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 23, 2024
@github-actions @opensearch-trigger-bot
[navigation-next] Fix issues. (#7356) (#7377) (#7379)
62bdc11 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

* Changeset file for PR #7305 created/updated

* feat: update

* feat: update with comment

* feat: update order and remove reset logic

* feat: update

* feat: update

* feat: update snapshot

* feat: some category change

* feat: update category

---------

* fix: bugs found in integration test

* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case

* fix: unit test error

* feat: revert back detect category

---------

(cherry picked from commit 8b46c44)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6551af7)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7adc980)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
[navigation-next] Fix issues. (#7356) (#7377) (#7379) (#7380)
0429e8a 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

* Changeset file for PR #7305 created/updated

* feat: update

* feat: update with comment

* feat: update order and remove reset logic

* feat: update

* feat: update

* feat: update snapshot

* feat: some category change

* feat: update category

---------

* fix: bugs found in integration test

* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case

* fix: unit test error

* feat: revert back detect category

---------

(cherry picked from commit 8b46c44)





(cherry picked from commit 6551af7)


(cherry picked from commit 7adc980)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 23, 2024
@github-actions @opensearch-trigger-bot
[navigation-next] Fix issues. (#7356) (#7377) (#7379) (#7380)
068033e 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

* Changeset file for PR #7305 created/updated

* feat: update

* feat: update with comment

* feat: update order and remove reset logic

* feat: update

* feat: update

* feat: update snapshot

* feat: some category change

* feat: update category

---------

* fix: bugs found in integration test

* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case

* fix: unit test error

* feat: revert back detect category

---------

(cherry picked from commit 8b46c44)

(cherry picked from commit 6551af7)

(cherry picked from commit 7adc980)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
(cherry picked from commit 0429e8a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
[navigation-next] Fix issues. (#7356) (#7377) (#7379) (#7380) (#7394)
293afd1 
* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

* Changeset file for PR #7305 created/updated

* feat: update

* feat: update with comment

* feat: update order and remove reset logic

* feat: update

* feat: update

* feat: update snapshot

* feat: some category change

* feat: update category

---------

* fix: bugs found in integration test

* Changeset file for PR #7356 created/updated

* feat: show workspace detail in all use case

* fix: unit test error

* feat: revert back detect category

---------

(cherry picked from commit 8b46c44)

(cherry picked from commit 6551af7)

(cherry picked from commit 7adc980)




(cherry picked from commit 0429e8a)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport main navigation v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuZhou-Joe @ruanyl