-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation] Update dev tools tab css for new left navigation #7328
Conversation
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 7328.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
@mengweieric @SuZhou-Joe Can you please help review the PR and backport this to 2.x? I am a first time contributor to OSD core. Would be grateful to understand if I am missing something here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7328 +/- ##
==========================================
- Coverage 67.53% 67.53% -0.01%
==========================================
Files 3504 3504
Lines 69407 69407
Branches 11324 11324
==========================================
- Hits 46874 46872 -2
- Misses 19773 19775 +2
Partials 2760 2760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Could you please post a screenshot of how the devTools will look like without query workbench plugin installed under your change? |
Could we check if the failing CI is relevant? |
Hi @SuZhou-Joe, This is how dev tool looks like without workbench |
* update dev tools tab css Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Changeset file for PR #7328 created/updated --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4c61906) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#7334) * update dev tools tab css * Changeset file for PR #7328 created/updated --------- (cherry picked from commit 4c61906) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
As part of new left navigation Workbench would be moved to dev tools. To make this happen we have registered workbench based on the new nav condition. The css in devtools is making the tabs justify apart
justify-content: space-between;
. Removing this css is fixing the UI and keeping it as expected. This PR removes the unnecessary css on dev tools Tab.Issues Resolved
Related Workbench PR: opensearch-project/dashboards-query-workbench#349
Screenshot
Before:
After:
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration