Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] refactor: density and consistency changes for discover and query bar #7321

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 54cdf23 from #7299.

…7299)

* refactor: density and consistency changes for discover and query ba

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 54cdf23)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.93%. Comparing base (9c6ac88) to head (decad23).

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7321   +/-   ##
=======================================
  Coverage   67.93%   67.93%           
=======================================
  Files        3455     3455           
  Lines       68462    68462           
  Branches    11150    11150           
=======================================
  Hits        46508    46508           
  Misses      19245    19245           
  Partials     2709     2709           
Flag Coverage Δ
Linux_1 33.19% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 42.89% <ø> (+0.01%) ⬆️
Windows_1 33.21% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 42.90% <ø> (ø)
Windows_4 34.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because test that failing is due to a flakey test

@virajsanghvi virajsanghvi merged commit acbfcaf into 2.x Jul 19, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset look & feel Look and Feel Improvements repeat-contributor v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants