Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Recover data source management in workspace #7296

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

raintygao
Copy link
Contributor

Description

Data source is a global level saved object, so we disable data source management when in workspace.
For now, data source is a workspace level object, so we should recover data source management in workspace and disable create/update/delete operation in frontend(#7214 has implemented).

Screenshot

image

Testing the changes

Enter a workspace then you can visit data source management then will see workspace level data source objects and there is not entry for creating/updating/deleting.

Changelog

  • feat: Recover data source management in workspace

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (2c6e78e) to head (fa77c07).
Report is 311 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/workspace/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7296   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        3501     3501           
  Lines       69343    69343           
  Branches    11305    11305           
=======================================
+ Hits        46808    46812    +4     
+ Misses      19779    19776    -3     
+ Partials     2756     2755    -1     
Flag Coverage Δ
Linux_1 33.11% <0.00%> (ø)
Linux_2 55.46% <ø> (ø)
Linux_3 43.05% <ø> (-0.01%) ⬇️
Linux_4 34.71% <ø> (ø)
Windows_1 33.13% <0.00%> (ø)
Windows_2 55.41% <ø> (ø)
Windows_3 43.06% <ø> (ø)
Windows_4 34.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Member

Hi @raintygao I think we can close this PR because:
When new navigation is enabled, we will show data source in each of the use case.
When new navigation is disabled, we had a assumption that workspace should be disabled as well.

@ZilongX
Copy link
Collaborator

ZilongX commented Jul 18, 2024

Pick up the main and re-running all checks

@ZilongX
Copy link
Collaborator

ZilongX commented Jul 18, 2024

Hi @raintygao I think we can close this PR because: When new navigation is enabled, we will show data source in each of the use case. When new navigation is disabled, we had a assumption that workspace should be disabled as well.

So do we still need this change to be merged as part of 2.16.0 ?

@raintygao
Copy link
Contributor Author

Hi @raintygao I think we can close this PR because: When new navigation is enabled, we will show data source in each of the use case. When new navigation is disabled, we had a assumption that workspace should be disabled as well.

So do we still need this change to be merged as part of 2.16.0 ?

Yes, after discussing we can merge it in 2.16 as this is a very tiny change. CC @SuZhou-Joe @ruanyl

@ruanyl ruanyl merged commit 352682b into opensearch-project:main Jul 19, 2024
68 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2024
* recover DSM in workspace

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7296 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 352682b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Jul 20, 2024
* recover DSM in workspace



* Changeset file for PR #7296 created/updated

---------




(cherry picked from commit 352682b)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants