Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Discover-next] remove plugin config toggle for data enhancements #7293

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Backport 2.x] [Discover-next] remove plugin config toggle for data enhancements #7293

merged 1 commit into from
Jul 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5761207 from #7291.

@github-actions @opensearch-changeset-bot
[Discover-next] remove plugin config toggle for data enhancements (#7291
90631f8 
)

* [Discover-next] remove plugin config toggle for data enhancements

Remove the data config toggle for enhancements and rely on the
UI settings for being enabled.

Issue Followup:
#7212

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix url

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* remove read only flag

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR #7291 created/updated

* set default to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5761207)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports distinguished-contributor v2.16.0 labels Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.73%. Comparing base (42140ca) to head (90631f8).
Report is 3 commits behind head on 2.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #7293   +/-   ##
=======================================
  Coverage   67.73%   67.73%           
=======================================
  Files        3452     3452           
  Lines       68309    68309           
  Branches    11113    11113           
=======================================
  Hits        46272    46272           
- Misses      19359    19360    +1     
+ Partials     2678     2677    -1
Flag Coverage Δ
Linux_1 33.32% <100.00%> (ø)
Linux_2 55.42% <ø> (ø)
Linux_3 45.05% <100.00%> (+<0.01%) ⬆️
Linux_4 34.85% <100.00%> (ø)
Windows_1 33.34% <100.00%> (ø)
Windows_2 55.37% <ø> (ø)
Windows_3 45.06% <100.00%> (ø)
Windows_4 34.85% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 merged commit bbc0286 into 2.x Jul 23, 2024
67 of 69 checks passed
abbyhu2000 pushed a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @abbyhu2000
[Discover-next] remove plugin config toggle for data enhancements (op…
9224956 
…ensearch-project#7291) (opensearch-project#7293)

* [Discover-next] remove plugin config toggle for data enhancements

Remove the data config toggle for enhancements and rely on the
UI settings for being enabled.

(cherry picked from commit 5761207)

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Jul 24, 2024
@abbyhu2000 @opensearch-trigger-bot
@github-actions @opensearch-changeset-bot
[Discover-next] remove plugin config toggle for data enhancements (#7291
425afd4 
) (#7293) (#7408)

* [Discover-next] remove plugin config toggle for data enhancements

Remove the data config toggle for enhancements and rely on the
UI settings for being enabled.

(cherry picked from commit 5761207)

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ananzh
[Discover-next] remove plugin config toggle for data enhancements (op…
9e05d00 
…ensearch-project#7291) (opensearch-project#7293)

* [Discover-next] remove plugin config toggle for data enhancements

Remove the data config toggle for enhancements and rely on the
UI settings for being enabled.

(cherry picked from commit 5761207)

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
@abbyhu2000 @opensearch-trigger-bot
@github-actions @opensearch-changeset-bot @ananzh
[Discover-next] remove plugin config toggle for data enhancements (op…
639a705 
…ensearch-project#7291) (opensearch-project#7293) (opensearch-project#7408)

* [Discover-next] remove plugin config toggle for data enhancements

Remove the data config toggle for enhancements and rely on the
UI settings for being enabled.

(cherry picked from commit 5761207)

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh mentioned this pull request Jul 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports distinguished-contributor failed changeset v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavilla @abbyhu2000