Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] include extra #7080

Closed
wants to merge 5 commits into from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 21, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.37%. Comparing base (d3d1c43) to head (b3ef419).
Report is 1 commits behind head on main.

Files Patch % Lines
src/dev/build/lib/runner.ts 20.00% 2 Missing and 2 partials ⚠️
packages/osd-pm/src/utils/opensearch_dashboards.ts 0.00% 2 Missing ⚠️
...es/osd-optimizer/src/optimizer/optimizer_config.ts 50.00% 0 Missing and 1 partial ⚠️
packages/osd-pm/src/config.ts 66.66% 0 Missing and 1 partial ⚠️
src/dev/build/lib/build.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7080      +/-   ##
==========================================
- Coverage   67.42%   67.37%   -0.06%     
==========================================
  Files        3448     3449       +1     
  Lines       67945    67960      +15     
  Branches    11052    11059       +7     
==========================================
- Hits        45813    45785      -28     
- Misses      19463    19478      +15     
- Partials     2669     2697      +28     
Flag Coverage Δ
Linux_1 33.05% <0.00%> (-0.01%) ⬇️
Linux_2 ?
Linux_3 45.24% <ø> (ø)
Linux_4 ?
Windows_1 33.07% <0.00%> (-0.01%) ⬇️
Windows_2 55.01% <55.55%> (+<0.01%) ⬆️
Windows_3 45.25% <ø> (ø)
Windows_4 34.81% <36.36%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant