Optimize scrolling behavior of Discover table #7017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an improvement to opensearch-project#6683 Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
github-actions
bot
added
distinguished-contributor
Skip-Changelog
AMoo-Miki
added
backport 2.x
v2.15.0
backport 2.15
and removed
Skip-Changelog
This is an improvement to opensearch-project#6683 Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
added
the
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7017 +/- ##
==========================================
+ Coverage 67.45% 67.46% +0.01%
==========================================
Files 3442 3442
Lines 67816 67816
Branches 11027 11027
==========================================
+ Hits 45742 45752 +10
+ Misses 19408 19397 -11
- Partials 2666 2667 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
approved these changes
Jun 13, 2024
manasvinibs
approved these changes
Jun 13, 2024
ZilongX
approved these changes
Jun 13, 2024
AMoo-Miki
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Optimize scrolling behavior of Discover table This is an improvement to #6683 (cherry picked from commit ebe2b9f) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Optimize scrolling behavior of Discover table This is an improvement to #6683 (cherry picked from commit ebe2b9f) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement to #6683
To prevent influencing the auto-sizing, this change unset the column widths from a previous render. It results in a much better auto-sizing outcome.
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration