Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] docs: remove attributes. in SavedObjectsFindOptions.fields example #6917

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[Backport 2.x] docs: remove attributes. in SavedObjectsFindOptions.fields example #6917

merged 1 commit into from
Jun 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 31b79e4 from #4695.

@github-actions @joshuarrrr
remove attributes. in comments for SavedObjectsFindOptions.fields (#…
8838e95 
…4695)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 31b79e4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added needs more info Requires more information from poster autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry first-time-contributor v2.15.0 labels Jun 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (8650bd9) to head (8838e95).

Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #6917   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files        3443     3443           
  Lines       67881    67881           
  Branches    11027    11027           
=======================================
  Hits        45792    45792           
  Misses      19426    19426           
  Partials     2663     2663
Flag Coverage Δ
Linux_1 33.10% <ø> (ø)
Linux_2 55.15% <ø> (ø)
Linux_3 45.28% <ø> (+0.01%) ⬆️
Linux_4 34.95% <ø> (ø)
Windows_1 33.12% <ø> (ø)
Windows_2 55.12% <ø> (ø)
Windows_3 45.28% <ø> (ø)
Windows_4 34.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhyuanqi zhyuanqi merged commit 1f7fb99 into 2.x Jun 5, 2024
93 of 94 checks passed
@github-actions github-actions bot deleted the backport/backport-4695-to-2.x branch June 5, 2024 04:58
@zhyuanqi zhyuanqi added the docs Improvements or additions to documentation label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@BionIT BionIT BionIT approved these changes

@zhyuanqi zhyuanqi zhyuanqi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports docs Improvements or additions to documentation first-time-contributor needs more info Requires more information from poster Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@virajsanghvi @BionIT @zhyuanqi