[VisBuilder] Change VisBuilder from experimental to production #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
|
cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/experimental.spec.js would need to be removed after merge. Right now this cypress test is expected to fail. PR to remove the failed test opensearch-project/opensearch-dashboards-functional-test#1217 |
ananzh
force-pushed
the
remove-experimental
branch
from
fb264ce
to
06feb38
Compare
1 task
ananzh
force-pushed
the
remove-experimental
branch
2 times, most recently
from
dedfc47
to
a806449
Compare
|
@ananzh should we add the 2.15 label or did we want to not commit to a specific release incase anything pops up from 2.14 to 2.15? |
ruanyl
previously approved these changes
May 8, 2024
7 tasks
|
@ananzh Could you resolve the conflict? |
ananzh
force-pushed
the
remove-experimental
branch
from
a806449
to
18a67da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6436 +/- ##
==========================================
- Coverage 67.45% 66.96% -0.49%
==========================================
Files 3443 2686 -757
Lines 67815 51619 -16196
Branches 11033 9322 -1711
==========================================
- Hits 45742 34569 -11173
+ Misses 19406 14775 -4631
+ Partials 2667 2275 -392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Jun 7, 2024
virajsanghvi
approved these changes
Jun 7, 2024
ruanyl
approved these changes
Jun 7, 2024
|
Seems DCO check failed. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [VisBuilder] Change VisBuilder from experimental to production Issue Resolve #6435 * Changeset file for PR #6436 created/updated --------- Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 75e6087) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Jun 7, 2024
#6971) * [VisBuilder] Change VisBuilder from experimental to production Issue Resolve #6435 * Changeset file for PR #6436 created/updated --------- (cherry picked from commit 75e6087) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
visualize:enableLabs, visbuilder can still be loaded in dashboardIssues Resolved
#6435
Changelog
Testing the changes
Check List
yarn test:jestyarn test:jest_integration