[Backport 2.x] [Multiple DataSource] DataSourceSelectable support to render label by getting it from dataSourceOptions #6382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… getting it from dataSourceOptions (#6358) * get label from dataSourceOptions Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update dataSourceOptions Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update changelog Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix failed test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * address comments and fix test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update selected option checked status and udpate snapshot Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update selectable test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * revert example code Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * revern config file Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * push the utils Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * udpate snapshot Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * remove console log Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * udate default data source Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * remove unnessary check for empty input Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix failed test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix failed test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> --------- Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> (cherry picked from commit 85df662) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
ZilongX
approved these changes
Apr 9, 2024
BionIT
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 85df662 from #6358.