-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[manual backport 2.x][MDS] Install Vega sample data (#6218) #6299
[manual backport 2.x][MDS] Install Vega sample data (#6218) #6299
Conversation
* Add data_source_name to sample data install Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add unit test coverage Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Resolve CHANGELOG.md conflicts Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactor logic Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Remove newline Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Remove newline Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add comments for spacing Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Update jsdoc Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> --------- Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> (cherry picked from commit 8810f08)
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6299 +/- ##
==========================================
+ Coverage 67.29% 67.31% +0.01%
==========================================
Files 3342 3342
Lines 64757 64766 +9
Branches 10372 10375 +3
==========================================
+ Hits 43581 43594 +13
+ Misses 18655 18651 -4
Partials 2521 2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for this change. In front of the PR title would you mind to add "[Manual Backport 2.x]"? Thanks Also Changelog check failed but I don't think we need to include changefile.md changes in backport PR. Folks, what do you think? @bandinib-amzn @ZilongX @Flyingliuhub @BionIT |
backport doesn't need changelog if I understand correctly, and If a changelog was not included, you can add the tag 'skip-changelog' check. |
I am seeing commit history in PR overview. Please remove it. See other manual backport for reference. |
Manual backport of #6218 into
2.x