[Backport 2.x] Handles auth methods from auth registry in DataSourceSavedObjectsClientWrapper #6096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6096 +/- ##
==========================================
- Coverage 67.13% 67.11% -0.03%
==========================================
Files 3315 3316 +1
Lines 63895 64048 +153
Branches 10189 10230 +41
==========================================
+ Hits 42897 42983 +86
- Misses 18525 18580 +55
- Partials 2473 2485 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xinruiba
approved these changes
Mar 8, 2024
tianleh
approved these changes
Mar 8, 2024
|
Before rebase, all checks are passing except WhiteSource Security check (which is known). |
…ntWrapper (#6062) * Handles auth methods from auth registry while saving data source Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Add more UT and remove repetitive code Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Adds changelog Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Refactor code Signed-off-by: Bandini Bhopi <bandinib@amazon.com> --------- Signed-off-by: Bandini Bhopi <bandinib@amazon.com> (cherry picked from commit 9f3a689) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
bandinib-amzn
force-pushed
the
backport/backport-6062-to-2.x
branch
from
9678529
to
fd3c3a1
Compare
Flyingliuhub
approved these changes
Mar 9, 2024
ZilongX
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9f3a689 from #6062.