Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi Data Source] Render credential form registered from AuthMethod #6002

Merged
merged 12 commits into from
Mar 5, 2024
Merged

[Multi Data Source] Render credential form registered from AuthMethod #6002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b128a67
[TokenExchange] Render credential form registered from AuthMethod
xinruiba Mar 2, 2024
1a620b7
[UT] Add unittest to test registered credential form get rendered in …
xinruiba Mar 2, 2024
e3edb61
[UT] Update test case descriptions
xinruiba Mar 2, 2024
d2de849
[Token Exchange] improve code format in create datasource page
xinruiba Mar 2, 2024
ba71c8a
[UT] Add unit test for edit datasource page
xinruiba Mar 2, 2024
cb0f0c3
Merge branch 'main' into xinrui_Token_Exchange_CredentialForm
xinruiba Mar 2, 2024
3570c97
Update changelog file
xinruiba Mar 2, 2024
249e175
update yml config file to original status
xinruiba Mar 2, 2024
ce49e74
Merge branch 'main' into xinrui_Token_Exchange_CredentialForm
xinruiba Mar 4, 2024
c907071
Resolving comments
xinruiba Mar 4, 2024
930adf8
[UT] Add more unit test to cover existing auth type and plugin regist…
xinruiba Mar 4, 2024
b55ddb3
Resolving comments, update pmport path
xinruiba Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Resolving comments, update pmport path 
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
  • Loading branch information
@xinruiba
xinruiba committed Mar 4, 2024
commit b55ddb3b409de95885006f00721b892206966637
2 changes: 1 addition & 1 deletion ...c/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
} from '@elastic/eui';
import { i18n } from '@osd/i18n';
import { FormattedMessage } from '@osd/i18n/react';
import { AuthenticationMethodRegistery } from 'src/plugins/data_source_management/public/auth_registry';
import { AuthenticationMethodRegistery } from '../../../../auth_registry';
import { SigV4Content, SigV4ServiceName } from '../../../../../../data_source/common/data_sources';
import {
AuthType,
Expand Down Expand Up @@ -325,7 +325,7 @@
};

handleStateChange = (state: any) => {
this.setState(state);

Check warning on line 328 in src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx#L328 

Added line #L328 was not covered by tests
};

getCredentialFormFromRegistry = (authType: string) => {
Expand All @@ -338,7 +338,7 @@
return authCredentialForm(this.state, this.handleStateChange);
}

return null;

Check warning on line 341 in src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx#L341 

Added line #L341 was not covered by tests
};

/* Render methods */
Expand Down
5 changes: 1 addition & 4 deletions ...nt/public/components/edit_data_source/components/edit_form/edit_data_source_form.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ import {
sigV4AuthMethod,
usernamePasswordAuthMethod,
} from '../../../../types';
import {
AuthenticationMethod,
AuthenticationMethodRegistery,
} from 'src/plugins/data_source_management/public/auth_registry';
import { AuthenticationMethod, AuthenticationMethodRegistery } from '../../../../auth_registry';

const titleFieldIdentifier = 'dataSourceTitle';
const titleFormRowIdentifier = '[data-test-subj="editDataSourceTitleFormRow"]';
Expand Down
2 changes: 1 addition & 1 deletion ...agement/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
} from '@elastic/eui';
import { i18n } from '@osd/i18n';
import { FormattedMessage } from '@osd/i18n/react';
import { AuthenticationMethodRegistery } from 'src/plugins/data_source_management/public/auth_registry';
import { AuthenticationMethodRegistery } from '../../../../auth_registry';
import { SigV4Content, SigV4ServiceName } from '../../../../../../data_source/common/data_sources';
import { Header } from '../header';
import {
Expand Down Expand Up @@ -525,7 +525,7 @@
};

handleStateChange = (state: any) => {
this.setState(state);

Check warning on line 528 in src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx#L528 

Added line #L528 was not covered by tests
};

getCredentialFormFromRegistry = (authType: string) => {
Expand All @@ -538,7 +538,7 @@
return authCredentialForm(this.state, this.handleStateChange);
}

return null;

Check warning on line 541 in src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx#L541 

Added line #L541 was not covered by tests
};

/* Render methods */
Expand Down
Loading