Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 1.3] Add package resolution for @babel/traverse #5564

Merged

Conversation

abbyhu2000
Copy link
Member

Description

Add package resolution for @babel/traverse. Manual backport PR for 1.3 from #5309.

Issues Resolved

#5303

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 marked this pull request as ready for review December 1, 2023 00:48
@abbyhu2000 abbyhu2000 changed the title Add package resolution for @babel/traverse [Manual Backport 1.3] Add package resolution for @babel/traverse Dec 1, 2023
@abbyhu2000 abbyhu2000 self-assigned this Dec 1, 2023
@abbyhu2000 abbyhu2000 added the autocut Skip the changelog verification check on backports label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3742fe2) 67.50% compared to head (464b259) 67.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.3    #5564      +/-   ##
==========================================
- Coverage   67.50%   67.49%   -0.01%     
==========================================
  Files        3044     3044              
  Lines       58692    58702      +10     
  Branches     8902     8902              
==========================================
+ Hits        39619    39621       +2     
- Misses      16925    16931       +6     
- Partials     2148     2150       +2     
Flag Coverage Δ
Linux 67.44% <ø> (-0.02%) ⬇️
Windows 67.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred the multiple uses of these to be merged in the lock file:

@babel/generator
@babel/helper-validator-identifier
@babel/parser
@babel/types

@joshuarrrr
Copy link
Member

I would have preferred the multiple uses of these to be merged in the lock file:

@babel/generator
@babel/helper-validator-identifier
@babel/parser
@babel/types

Yeah, I recall from my work on the root cause of this (fixing without a resolution), that some of these need to be done carefully, because they actually cause issues (even though they shouldn't.

@joshuarrrr joshuarrrr merged commit 7523e30 into opensearch-project:1.3 Dec 4, 2023
34 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v1.3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants