[Chore] --security for snapshot and OSD server
#5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
ananzh,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5451 +/- ##
==========================================
- Coverage 66.98% 66.95% -0.04%
==========================================
Files 3293 3293
Lines 63281 63285 +4
Branches 10061 10061
==========================================
- Hits 42389 42370 -19
- Misses 18451 18470 +19
- Partials 2441 2445 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
force-pushed
the
kavilla/aasecurity
branch
from
8eed647
to
25fc270
Compare
ananzh
previously approved these changes
Nov 10, 2023
AMoo-Miki
reviewed
Nov 11, 2023
AMoo-Miki
reviewed
Nov 11, 2023
AMoo-Miki
reviewed
Nov 11, 2023
package.json
Outdated
| @@ -64,6 +64,8 @@ | |||
| "build": "scripts/use_node scripts/build --all-platforms", | |||
| "start": "scripts/use_node scripts/opensearch_dashboards --dev", | |||
| "start:docker": "scripts/use_node scripts/opensearch_dashboards --dev --opensearch.hosts=$OPENSEARCH_HOSTS --opensearch.ignoreVersionMismatch=true --server.host=$SERVER_HOST", | |||
| "start:security": "scripts/use_node scripts/opensearch_dashboards --dev --security", | |||
| "start:security:default": "export OPENSEARCH_USERNAME=kibanaserver && export OPENSEARCH_PASSWORD=kibanaserver && scripts/use_node scripts/opensearch_dashboards --dev --security", | |||
There was a problem hiding this comment.
I’m not comfortable with this. Where is this default defined? Is it something we use in CI or is it a default for OS?
There was a problem hiding this comment.
Yeah I was uncomfortable with this. It is the demo user for OpenSearch Dashboards defined by the OpenSearch Security plugin:
https://github.com/opensearch-project/security/blob/main/config/internal_users.yml#L27
AMoo-Miki
reviewed
Nov 11, 2023
7 tasks
Add the ability to run: ``` yarn opensearch snapshot --security ``` which will start the OpenSearch cluster with the security plugin. And add the ability to run: ``` yarn start:security ``` which will start the OpenSearch Dashboards server if the security plugin is available. This is only intended for demo and local purposes. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
kavilla/aasecurity
branch
from
f89bf8a
to
15d8962
Compare
abbyhu2000
approved these changes
Nov 28, 2023
| > 3. Wait a few seconds while the plugin is installed, configured, and OpenSearch starts up. | ||
|
|
||
| Then within another window. You can start: | ||
|
|
There was a problem hiding this comment.
Should we also add a step here to clone the dashboard-security repo under /plugins?
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Add the ability to run: ``` yarn opensearch snapshot --security ``` which will start the OpenSearch cluster with the security plugin. And add the ability to run: ``` yarn start:security ``` which will start the OpenSearch Dashboards server if the security plugin is available. This is only intended for demo and local purposes. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 2e7a2ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
added a commit
that referenced
this pull request
Nov 30, 2023
Add the ability to run: ``` yarn opensearch snapshot --security ``` which will start the OpenSearch cluster with the security plugin. And add the ability to run: ``` yarn start:security ``` which will start the OpenSearch Dashboards server if the security plugin is available. This is only intended for demo and local purposes. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Dec 11, 2023
Add the ability to run: ``` yarn opensearch snapshot --security ``` which will start the OpenSearch cluster with the security plugin. And add the ability to run: ``` yarn start:security ``` which will start the OpenSearch Dashboards server if the security plugin is available. This is only intended for demo and local purposes. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
ananzh
pushed a commit
that referenced
this pull request
Dec 12, 2023
Add the ability to run: ``` yarn opensearch snapshot --security ``` which will start the OpenSearch cluster with the security plugin. And add the ability to run: ``` yarn start:security ``` which will start the OpenSearch Dashboards server if the security plugin is available. This is only intended for demo and local purposes. Issue: n/a (cherry picked from commit 2e7a2ba) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to run:
which will start the OpenSearch cluster with the security plugin.
And add the ability to run:
which will start the OpenSearch Dashboards server if the security plugin is available.
This is only intended for demo and local purposes.
Issue:
n/a
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration