[Data Explorer] Fix share link of save search #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
abbyhu2000
added
de-angular
manasvinibs
approved these changes
Oct 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #5324 +/- ##
=======================================
Coverage 66.81% 66.81%
=======================================
Files 3286 3286
Lines 63148 63148
Branches 10054 10054
=======================================
Hits 42191 42191
Misses 18475 18475
Partials 2482 2482
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavilla
approved these changes
Oct 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit e1db842) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit e1db842) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Oct 20, 2023
(cherry picked from commit e1db842) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Oct 23, 2023
Fixes: #5323 (cherry picked from commit e1db842) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix share link issue of save search for data explorer.
Issues Resolved
resolves #5323
Screenshot
Screen.Recording.2023-10-18.at.4.17.19.PM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integration