Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace][Feature]Setup workspace skeleton and implement basic CRUD API #5075
[Workspace][Feature]Setup workspace skeleton and implement basic CRUD API #5075
Changes from 17 commits
1148ed1
a7c0337
9a3f713
5f6f4c3
0449cdd
ebc1286
16a4c66
759d03c
6e1c656
090e2fe
bf53f12
d0d5882
2f73b21
5219fce
e80221e
46238e1
87e8f71
86871a5
bdb93cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think savedObjects is one I suggested. Just in case, I would suggest in a follow-up verifying all your requiredPlugins and bundles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the
WorkspaceClient
is a wrapper on top of savedObjectClient, which we usually do not do for other saved object types. Is there a specific reason we want a heavy client for workspace type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the client now is a simple wrapper on top of savedObjectClient but in the following PRs more logic will be added into this client, and this PR is intended to setup the skeleton for them. And this client won't be too
heavy
as there will be only a single instance for each OSD server and we do not have any side effect inside the client.