Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixes broken app when management is turned off #4904

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1068939 from #4891.

* fixes broken app when management is turned off

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* updates changelog

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 1068939)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #4904 (bdb86e0) into 2.x (a47e612) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              2.x    #4904      +/-   ##
==========================================
- Coverage   66.44%   66.44%   -0.01%     
==========================================
  Files        3398     3398              
  Lines       64871    64873       +2     
  Branches    10358    10359       +1     
==========================================
+ Hits        43102    43103       +1     
- Misses      19211    19212       +1     
  Partials     2558     2558              
Flag Coverage Δ
Linux_1 34.91% <0.00%> (-0.01%) ⬇️
Linux_2 55.18% <ø> (ø)
Linux_3 44.20% <0.00%> (ø)
Linux_4 35.09% <0.00%> (-0.01%) ⬇️
Windows_1 34.92% <0.00%> (-0.01%) ⬇️
Windows_2 55.15% <ø> (ø)
Windows_3 44.21% <0.00%> (+<0.01%) ⬆️
Windows_4 35.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...page/overview_page_footer/overview_page_footer.tsx 50.00% <0.00%> (-10.00%) ⬇️
...ugins/vis_augmenter/public/ui_actions_bootstrap.ts 5.88% <0.00%> (-0.79%) ⬇️

... and 1 file with indirect coverage changes

@AMoo-Miki AMoo-Miki merged commit 5a07a92 into 2.x Sep 5, 2023
71 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-4891-to-2.x branch September 5, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants