Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Implement column actions #4756

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 16, 2023

Description

restore columns actions
Screenshot 2023-08-16 at 14 27 43

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh force-pushed the feature/data-explorer-table-update branch from 7d31153 to 7aab131 Compare August 17, 2023 23:03
@ashwin-pc ashwin-pc changed the title [Data Explorer][Discover 2.0] Emplement column actions [Data Explorer][Discover 2.0] Implement column actions Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #4756 (7d31153) into feature/data-explorer (521f306) will decrease coverage by 11.27%.
Report is 6 commits behind head on feature/data-explorer.
The diff coverage is 40.33%.

❗ Current head 7d31153 differs from pull request most recent head c96dcb3. Consider uploading reports for the commit c96dcb3 to get more accurate results

@@                    Coverage Diff                     @@
##           feature/data-explorer    #4756       +/-   ##
==========================================================
- Coverage                  66.50%   55.24%   -11.27%     
==========================================================
  Files                       3289     2243     -1046     
  Lines                      62821    41957    -20864     
  Branches                    9788     7291     -2497     
==========================================================
- Hits                       41782    23178    -18604     
+ Misses                     18658    17466     -1192     
+ Partials                    2381     1313     -1068     
Flag Coverage Δ
Linux_2 55.04% <84.33%> (?)
Linux_4 35.10% <14.56%> (?)
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/server/legacy/legacy_service.ts 75.38% <ø> (ø)
src/core/server/plugins/plugin_context.ts 45.45% <ø> (ø)
src/core/server/rendering/views/template.tsx 100.00% <ø> (ø)
...server/saved_objects/saved_objects_service.mock.ts 100.00% <ø> (ø)
...aved_objects/service/lib/scoped_client_provider.ts 100.00% <ø> (ø)
... and 44 more

... and 1608 files with indirect coverage changes

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc merged commit 9a46a7c into opensearch-project:feature/data-explorer Aug 17, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants