Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix line to vega conversion bug #4557

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b94a62f from #4554.

@opensearch-trigger-bot opensearch-trigger-bot bot added the autocut Skip the changelog verification check on backports label Jul 12, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry valued-contributor labels Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #4557 (df28cbd) into 2.x (df28cbd) will not change coverage.
The diff coverage is n/a.

❗ Current head df28cbd differs from pull request most recent head 9faf339. Consider uploading reports for the commit 9faf339 to get more accurate results

@@           Coverage Diff           @@
##              2.x    #4557   +/-   ##
=======================================
  Coverage   66.13%   66.13%           
=======================================
  Files        3315     3315           
  Lines       63887    63887           
  Branches     9963     9963           
=======================================
  Hits        42254    42254           
  Misses      19187    19187           
  Partials     2446     2446           
Flag Coverage Δ
Linux_1 34.73% <0.00%> (ø)
Linux_2 55.07% <0.00%> (ø)
Linux_3 43.23% <0.00%> (ø)
Linux_4 35.09% <0.00%> (ø)
Windows_1 34.76% <0.00%> (ø)
Windows_3 43.23% <0.00%> (ø)
Windows_4 35.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

* Fix line to vega conversion bug

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Update CHANGELOG and release notes

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Address comments

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Add more details to comment

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Not a released changed, so no need to document

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit b94a62f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@lezzago lezzago force-pushed the backport/backport-4554-to-2.x branch from da4ee72 to 9faf339 Compare July 12, 2023 23:56
@joshuarrrr joshuarrrr merged commit 6a8e151 into 2.x Jul 19, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-4554-to-2.x branch July 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants