Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard De-Angularization #4502

Merged
merged 24 commits into from
Jul 11, 2023
Merged

Dashboard De-Angularization #4502

merged 24 commits into from
Jul 11, 2023

Commits on Jul 7, 2023

  1. Replace angular modules with react components

    Use React to start up the dashboard app, and use react routing to configure basic
    routing for dashboard plugin.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b6a783d View commit details
    Browse the repository at this point in the history
  2. Skip dashboard state unit test

    Will revisit when the proper state management is added.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    527dc99 View commit details
    Browse the repository at this point in the history
  3. [Dashboard De-Angular] Render dashboard listing page (#4015)

    Render the dashboard listing component with basic functionalities:
    * When there is no dashboard, render the empty dashboard page
    * When there are dashboards, show the dashboard listing table
    * When click on the dashboard, show the editor page
    * Delete the dashboards when selected
    * Can use search bar to filter dashboard
    
    TODO:
    
    * use URL param to filter dashboards based on dashboard titles
    * implement actions column
    * global persistence on the listing page
    
    Issue Resolved:
    #4000
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1d36377 View commit details
    Browse the repository at this point in the history
  4. Basic top nav bar for dashboard (#4108)

    Basic top nav bar for dashboard
    
    This PR will add basic structure to render top nav bar, including a basic implementation for dashboard app state. This is not functionality complete, but to help implement a basic working dashboard app as the first step.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d42fb8d View commit details
    Browse the repository at this point in the history
  5. Render editor page with basic nav actions (#4213)

    Added dashboard embeddable container to render the dashboard editor page.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    492cbad View commit details
    Browse the repository at this point in the history
  6. Add visualization (#4257)

    Add and save visualization to dashboard
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c260669 View commit details
    Browse the repository at this point in the history
  7. Render empty screen (#4346)

    Render empty screen with correct edit and view view when creating a new dashboard.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f9582df View commit details
    Browse the repository at this point in the history
  8. Fix routing (#4357)

    Fix the edit action routing on the dashboard listing page; also fix routing when the route has no match. Add '_g' param to the URL on both dashboard
    listing page and dashboard editor page.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    70f07d7 View commit details
    Browse the repository at this point in the history
  9. [Dashboard De-Angular] Enable time filter functionalities (#4364)

    * Fix time filter on dashboard
    
    * Save dashboard with time restore
    
    * Dashboard be able to save query and app filter
    
    * Enable functional test for dashboard
    
    * Fix comments and add ui bootstrap back
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    287edc3 View commit details
    Browse the repository at this point in the history
  10. No index pattern routing (#4401)

    Should redirect to stack management page if there is no index pattern detected.
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    fcca6a5 View commit details
    Browse the repository at this point in the history
  11. Add embed mode and other URL param options (#4407)

    UI should render based on URL param options
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1fc629c View commit details
    Browse the repository at this point in the history
  12. [Dashboard De-Angular] Add dashboard class for discard flow (#4478)

    * Add Dashboard class for state managing
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * isDirty working for cancel flow
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e22e012 View commit details
    Browse the repository at this point in the history
  13. [Dashboard De-Angular] Add breadcrumb with view/edit mode and unsaved…

    … flow (#4479)
    
    * set isDirty back to false when saving susccessfully
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Breadcrumb working
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * change to dashboards in breadcrumb
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d6249fb View commit details
    Browse the repository at this point in the history
  14. [Dashboard De-Angular] Enable URL title param for initial filter on d…

    …ashboard listing (#4480)
    
    * Fix dashboard listing functional test
    
    Can filter dashboards using URL title param
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Fix the functional tests
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    bf225cd View commit details
    Browse the repository at this point in the history
  15. [Dashboard De-Angular] Fix dashboard save and back button functional …

    …test (#4491)
    
    * fix copy on save and functional test 5
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Fix back button navigation
    
    -- Fix version migration for panels
    -- Fix conversions between saved panel and container panel type
    -- Fix redundant browser update by re-structure app state and global state sync logic in order for back button to work, also fix the corresponding functional test
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * migration version
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Add initialization dirty flag and fix full mode filter bar
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Add initialization dirty flag and fix full mode filter bar
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2538201 View commit details
    Browse the repository at this point in the history
  16. [Dashboard De-Angular] Fix filter and query related functional tests …

    …in functional test group 3 (#4495)
    
    * fix index pattern window
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Fix time filter and query related functionalt test in group 3
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    56eb1a2 View commit details
    Browse the repository at this point in the history
  17. [Dashboard De-Angular] Fix remaining functional test (#4496)

    * fix dashboard state function test in group 4
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * fix expanding panel
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    469526f View commit details
    Browse the repository at this point in the history
  18. fix observibility dashboard delete (#4508)

    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f8d5e82 View commit details
    Browse the repository at this point in the history
  19. [Dashboard De-Angular] Initial clean up and linter fix (#4511)

    * Clean up linter issues
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * Add changelog and other fixes
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2ea2885 View commit details
    Browse the repository at this point in the history
  20. [Dashboard De-Angular] Cypress fix (#4521)

    * fix cypress
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    * refactor css files
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    
    ---------
    
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    cfa9087 View commit details
    Browse the repository at this point in the history
  21. delete old unit test

    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    abbyhu2000 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    98a6b4b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Refactor app state and cleanup unused imports (#4504)

    Clean up app state for Dashboards plugin.
    
    * Removes the dashboard container hook in place of a single dashboard app state container
    * Still recovers some follow-ups and clean up
    * Skips test for rendering of a legacy test.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    
    ---------
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
    Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
    Co-authored-by: Miki <amoo_miki@yahoo.com>
    3 people authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bd72786 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into feature/deangular-dashboards

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2358bf3 View commit details
    Browse the repository at this point in the history
  3. Set dashboard container functions and fix license headers (#4540)

    * Set dashboard container after defining functions
      * renderEmpty was not being set prior to the current container was being dispatched.
    * fix up license headers for new files
    * add TODOs from PR
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5c1a419 View commit details
    Browse the repository at this point in the history