Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore (VisBuilder): Update icon to use OUI icon #4446

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Chore (VisBuilder): Update icon to use OUI icon #4446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cf7e82
Chore (VisBuilder): Update icon to use OUI icon
joshuarrrr Jun 29, 2023
0e4fc24
update changelog
joshuarrrr Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/plugins/vis_builder/public/assets/vis_builder_icon.svg
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions src/plugins/vis_builder/public/assets/vis_builder_icon_secondary_fill.svg
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/plugins/vis_builder/public/embeddable/vis_builder_embeddable_factory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
VisBuilderOutput,
VISBUILDER_EMBEDDABLE,
} from './vis_builder_embeddable';
import visBuilderIcon from '../assets/vis_builder_icon.svg';
import { getStateFromSavedObject } from '../saved_visualizations/transforms';
import {
getHttp,
Expand Down Expand Up @@ -55,7 +54,7 @@ export class VisBuilderEmbeddableFactory
name: PLUGIN_NAME,
includeFields: ['visualizationState'],
type: VISBUILDER_SAVED_OBJECT,
getIconForSavedObject: () => visBuilderIcon,
getIconForSavedObject: () => 'visBuilder',
};

// TODO: Would it be better to explicitly declare start service dependencies?
Expand Down
6 changes: 2 additions & 4 deletions src/plugins/vis_builder/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ import {
VisBuilderStart,
} from './types';
import { VisBuilderEmbeddableFactory, VISBUILDER_EMBEDDABLE } from './embeddable';
import visBuilderIconSecondaryFill from './assets/vis_builder_icon_secondary_fill.svg';
import visBuilderIcon from './assets/vis_builder_icon.svg';
import {
EDIT_PATH,
PLUGIN_ID,
Expand Down Expand Up @@ -189,7 +187,7 @@ export class VisBuilderPlugin
description: i18n.translate('visBuilder.visPicker.description', {
defaultMessage: 'Create visualizations using the new VisBuilder',
}),
icon: visBuilderIconSecondaryFill,
icon: 'visBuilder',
stage: 'experimental',
aliasApp: PLUGIN_ID,
aliasPath: '#/',
Expand All @@ -200,7 +198,7 @@ export class VisBuilderPlugin
description: attributes?.description,
editApp: PLUGIN_ID,
editUrl: `${EDIT_PATH}/${encodeURIComponent(id)}`,
icon: visBuilderIcon,
icon: 'visBuilder',
id,
savedObjectType: VISBUILDER_SAVED_OBJECT,
stage: 'experimental',
Expand Down