[Feature Anywhere] Fix unrelated changes to be synced with main #4414
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX and
Flyingliuhub
as code owners
ohltyler
requested review from
lezzago
and removed request for
seanneumann,
AMoo-Miki,
kavilla,
zhongnansu,
Flyingliuhub,
abbyhu2000,
zengyan-amazon,
ananzh,
ZilongX,
kristenTian and
manasvinibs
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #4414 +/- ##
============================================================
+ Coverage 66.43% 66.45% +0.01%
============================================================
Files 3287 3287
Lines 63258 63256 -2
Branches 9796 9796
============================================================
+ Hits 42026 42037 +11
+ Misses 18868 18855 -13
Partials 2364 2364
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| /** | ||
| * Unique ID for the toast. Can be used to prevent duplicate toasts on re-renders. | ||
| */ | ||
| id?: string; |
There was a problem hiding this comment.
I remember this change being in main, do you know why this is deleted here?
There was a problem hiding this comment.
Actually, looks like this change is not in main. I think it exists in the feature branch since it was cherry-picked, perhaps from 2.x?
Do you recall the owner of that change, and can we get that front ported into main?
There was a problem hiding this comment.
In the meantime I will merge this since it was flagging this PR as adding this change, which is correct when compared with main currently. Removing it will remove this change from being related to this PR which is what we want.
There was a problem hiding this comment.
Oh shoot, yeah thanks catching that. Lemme look into why it's missing
There was a problem hiding this comment.
I see it is not in 2.x either actually..
Description
Fix unrelated changes / revert some changes such that they are synced with main.
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr